Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100 MB in dependencies is way too much! #254

Open
rmberrios opened this issue Aug 5, 2019 · 5 comments
Open

100 MB in dependencies is way too much! #254

rmberrios opened this issue Aug 5, 2019 · 5 comments

Comments

@rmberrios
Copy link
Contributor

rmberrios commented Aug 5, 2019

Is there a way we can reduce the number of dependencies?
actions-on-google has 49MB and googleapis has 44 MB.

This issue is really troublesome due to lambda size limit of 250 MB

@rmberrios rmberrios pinned this issue Aug 5, 2019
@omenocal
Copy link
Contributor

omenocal commented Aug 5, 2019

@rmberrios I'm running a project with these dependencies:

"dependencies": {
    "lambda-log": "^2.3.0",
    "lodash": "^4.17.15",
    "raven": "^2.6.4",
    "serverless-sentry-lib": "^1.1.2",
    "voxa": "^3.3.0"
  }

I'm using voxa: 3.3.0 and when I zip my code I get a 17.1 MB zipped file. I remember we had an issue when Voxa included samples and even the documentation files. That made a voxa project to have a really big size as you described, but it was fixed with this PR:
#218

Which solved the issue: #217

@rmberrios
Copy link
Contributor Author

@omenocal See the folder without compression. Lambda size is based on the folder without compression.

@omenocal
Copy link
Contributor

omenocal commented Aug 6, 2019

Oh ok, I misunderstood the maximum size of the zipped file which is 75MB in Lambda

@wuelcas wuelcas unpinned this issue Oct 21, 2019
@armonge
Copy link
Contributor

armonge commented Oct 29, 2019

We should probably remove the botframework stuff, don't think anyone uses it and it's pretty outdated because of that. Also mark googleapis actions-on-google and ask-sdk-model as peer dependencies, those seem to be the biggest culprits of package cruft. Also, i've been thinking about actually splitting voxa to for example not require google stuff if you're just working with alexa and viceversa, however that seems like it would be a breaking change and lots of work to be honest

@spatical
Copy link
Contributor

Perhaps update with scoped dependencies? So only parts of Voxa can be imported if needed? https://stackoverflow.com/a/36667439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants