From 08d01cddfebf1693b5f564e21cd95b876d9f3ae3 Mon Sep 17 00:00:00 2001 From: Michael Heap Date: Fri, 12 Apr 2019 15:55:54 +0100 Subject: [PATCH] Add NCCO parameter support for PHP --- src/Call/Call.php | 5 +++ test/Call/CollectionTest.php | 59 ++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+) diff --git a/src/Call/Call.php b/src/Call/Call.php index 49b24bd1..abcf45ae 100644 --- a/src/Call/Call.php +++ b/src/Call/Call.php @@ -195,6 +195,11 @@ public function setTimeout($type, $length) $this->data[$type . '_timeout'] = $length; } + public function setNcco($ncco) { + $this->data['ncco'] = $ncco; + return $this; + } + public function getStatus() { if($this->lazyLoad()){ diff --git a/test/Call/CollectionTest.php b/test/Call/CollectionTest.php index 61cec0f3..c6e43b04 100644 --- a/test/Call/CollectionTest.php +++ b/test/Call/CollectionTest.php @@ -135,6 +135,26 @@ public function testCreatePostCall($payload, $method) $this->assertInstanceOf('Nexmo\Call\Call', $call); $this->assertEquals('e46fd8bd-504d-4044-9600-26dd18b41111', $call->getId()); } + + /** + * @dataProvider postCallNcco + */ + public function testCreatePostCallNcco($payload) + { + $this->nexmoClient->send(Argument::that(function(RequestInterface $request) use ($payload){ + $ncco = [['action' => 'talk', 'text' => 'Hello World']]; + + $this->assertRequestUrl('api.nexmo.com', '/v1/calls', 'POST', $request); + $this->assertRequestBodyIsJson(json_encode($payload), $request); + $this->assertRequestJsonBodyContains('ncco', $ncco, $request); + return true; + }))->willReturn($this->getResponse('created', '201')); + + $call = $this->collection->post($payload); + + $this->assertInstanceOf('Nexmo\Call\Call', $call); + $this->assertEquals('e46fd8bd-504d-4044-9600-26dd18b41111', $call->getId()); + } /** * @dataProvider postCall @@ -228,6 +248,45 @@ public function getCall() ]; } + /** + * Creating a call with an NCCO can take a Call object or a simple array. + * @return array + */ + public function postCallNcco() + { + $raw = [ + 'to' => [[ + 'type' => 'phone', + 'number' => '14843331234' + ]], + 'from' => [ + 'type' => 'phone', + 'number' => '14843335555' + ], + 'ncco' => [ + [ + 'action' => 'talk', + 'text' => 'Hello World' + ] + ] + ]; + + + $call = new Call(); + $call->setTo('14843331234') + ->setFrom('14843335555') + ->setNcco([ + [ + 'action' => 'talk', + 'text' => 'Hello World' + ] + ]); + + return [ + 'object' => [clone $call], + 'array' => [$raw] + ]; + } /** * Creating a call can take a Call object or a simple array. * @return array