Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how composite parts are rendered #92

Open
dany-fu opened this issue Sep 7, 2018 · 3 comments
Open

Change how composite parts are rendered #92

dany-fu opened this issue Sep 7, 2018 · 3 comments

Comments

@dany-fu
Copy link
Contributor

dany-fu commented Sep 7, 2018

Having to fetch all referenced SBOL objects can significantly slow down SBH.
VisBOL should only render the subdesign if the user clicks on the composite object

@cjmyers
Copy link
Collaborator

cjmyers commented Sep 7, 2018

Also, that rendering will happen naturally as it opens the page for the composite design to render that object. In other words, we should just render one level down at most.

@cjmyers
Copy link
Collaborator

cjmyers commented Oct 29, 2018

Here is an example that is missing definitions for referenced components. When you encounter a CD with Components that are missing their definitions, then do not render the CD.

BBa_F2620.zip

@cjmyers cjmyers assigned jvscholz and unassigned asadeg02 Mar 7, 2019
@cjmyers
Copy link
Collaborator

cjmyers commented Mar 7, 2019

Needs to be fixed in getDisplayList when converting SBOL to displayList

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants