Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Math calculations of day #18

Open
se7enek opened this issue May 19, 2019 · 3 comments
Open

[Enhancement] Math calculations of day #18

se7enek opened this issue May 19, 2019 · 3 comments

Comments

@se7enek
Copy link

se7enek commented May 19, 2019

Simple enough, imho easy to add.

Instead of making config for "Day: "1"", make it somewhere close to it (example below)

Day = 7 (day 7, simple enough)
Day % 7 = 0 (whenever remainder of dividing current day by 7 is equal to 0, so.. 14,21,28... (skipping day 7 cuz declared above)
Day > 5 (day 6,,8,9,10,11,12,13,,15 etc..., skipping both day 7 and every multiplification of 7)

That way player could do special functions with never-ending daily rewards.

Possible to do ? @skyfire55

@se7enek
Copy link
Author

se7enek commented May 19, 2019

Obviously, in above example players would NOT get rewards for Day 1,2,3,4,5 unless something like:
Day =< 5 is added
or Day = 1 || Day = 2 etc.

@VimbaTheFish
Copy link
Owner

Interesting idea.
I have plans to fully rewrite DailyRewards, coz now it seems a bit...hmm...old. I think i will add this function to new version, coz it seems usable. I will think about structure of this idea.

@se7enek
Copy link
Author

se7enek commented May 19, 2019

Not a pro coder, but make it like in if elseif format and store variable in the Day placeholder.

Simple:
Day == 5 { }
Day % 7 == 0 { }
Day > 5 { }

Would be "converted" to:
If (day == 5) {}
Else If (day % 7 == 0) { }
Else If (day > 5) { }

and that's it, i guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants