Fixes + tunnel colors + transparent latch outputs #179
Conversation
Tunnels are still separate gate, just derived from wire. Current problem: drop-down menu for wires almost goes off-screen, not sure how to fix properly.
| @@ -31,7 +32,7 @@ | |||
| public class CircuitData implements Cloneable { | |||
|
|
|||
| // cdata version | |||
| public static final int version = 1; | |||
| public static final int version = 2; | |||
There was a problem hiding this comment.
Note that the legacy loader doesn't work at all (because it doesn't do the steps in sequence, there's a big TODO on it), so if you decide to change the version it should probably be fixed first
There was a problem hiding this comment.
These steps are NBT, transform and postTransform. For what I did this is fine.
Anyway, the proper solution is to do conversion using separate "frozen" codebase that will never have to be changed. That is, no CircuitData or any other such classes. It should receive NBT and produce new NBT.
There was a problem hiding this comment.
I guess... Still would like to see that get fixed though
|
On the other side, I am currently not sure if I should unify wires and tunnels. When I first installed this mod I just was sure that there should be a way to do what I later found Edit: |
Done so by moving them up.
Added `allowsDragPlacement` method, currently only used for wires. Split wire/tunnel rendering into separate methods.
Just to be safe, they should "convert" properly anyway.
|
@evg-zhabotinsky Planning to finish this or should I pull? |
evg-zhabotinsky
changed the title
|
That's all I've done for now. |
Fixed #176
Fixed #174
Made same-colored wires connect more seamlessly (also removed unneeded holes in tunnel texture).
Made tunnels be derived from wires, so now they have colors. (#160)
Wire renderer now handles tunnels too, just draws background and always uses wire circle. (No straight lines.)
Disabled wire-like placement, added proper localized names.
Tunnels are otherwise unchanged.
Old tunnels are converted to green tunnels (one more small LegacyLoader), so no breaking changes.
Current problem: drop-down menu for wires almost goes off-screen and has zoom % printed on top of it.
Further plans: integrate tunnels with wires.
That is, convert tunnels to wires on disconnection and make tunnels by connecting wires.
This will also fix the above problem with drop-down menu, as tunnels will no longer be directly placeable.