Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long dictionary definitions don't fit on phone screen #113

Open
chuckdries opened this issue Aug 20, 2022 · 2 comments
Open

Long dictionary definitions don't fit on phone screen #113

chuckdries opened this issue Aug 20, 2022 · 2 comments
Labels
bug Something isn't working client

Comments

@chuckdries
Copy link
Collaborator

No description provided.

@chuckdries chuckdries added bug Something isn't working client labels Aug 20, 2022
@NguyenDa18
Copy link
Contributor

Screen Shot 2022-08-21 at 1 32 27 AM

I see the same as well -should a centered modal that takes up the whole screen until dismissed be considered instead of react-tiny-popup? I tried for half an hour to get tailwind overflow working so there are scrollbars in the div but no luck.

@chuckdries
Copy link
Collaborator Author

I was thinking maybe split the definitions up into pages, but I'd also be fine with a modal. Maybe we show just a sentence worth of definition and a "show more" button, and the show more button opens a modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client
Projects
None yet
Development

No branches or pull requests

2 participants