Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed connect should not trigger onClose, should log failure reason if possible #36

Open
niloc132 opened this issue Apr 3, 2020 · 0 comments

Comments

@niloc132
Copy link
Member

niloc132 commented Apr 3, 2020

Presently, if the checksum check fails for whatever reason, the Server.onOpen call never is invoked, but Server.onClose is, which doesn't make sense. Instead, it should not be called at all.

Additionally, those various failed checks should call in to some common log API, if possible, or at least offer the chance for the Server implementation to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant