Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Client P12 file for TFC #157

Open
peterees opened this issue Dec 4, 2024 · 4 comments
Open

Dynamic Client P12 file for TFC #157

peterees opened this issue Dec 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@peterees
Copy link

peterees commented Dec 4, 2024

Have been engaging with Peter Fiddles via Customer Success Engineer

BUSINESS PROBLEM
We have been looking to consume the terraform provider for Venafi to enable automation and update business processes for developers using TFC within our organisation. We have written a wrapper module that replaces manual checks for custom field and other metadata that requesters that are required to provide so that we can streamline the registration authority's processes.

Via the provider config we have been able to utilise cloud native secrets management solutions to dynamically provide trust bundle and client P12 password all for consumers to utilise, however was not successfully able to provide the p12 file through this way due to what we believe is how TFC operates with files potentially not being present on the local runner's filesystem when dynamically being pulled at plan / apply stages.

We chose client cert authentication for our organisation after looking at the variety of mechanisms and found this was the best that suited our needs.

PROPOSED SOLUTION
Please investigate updating the venafi provider to allow for the client certificate p12 to be provided in a more dynamic fashion so that we can achieve our vision of providing a just in time access model to sensitive data and files.

CURRENT ALTERNATIVES
We are currently having to keep the p12 within our codebase so that it is then provided to the runner on execution within TFC.

VENAFI EXPERIENCE
We have utilised Venafi for approximately 10 years however automation of this kind has been something we have been pushing forward within the last 6-8 months as we adopt more devops and agile methods within our organisation. By providing this we can truely allow developers to move at speed and remove roadblocks of requiring manual stages within our certificate request process and championing ongoing utilisation of such enterprise products.

@peterees peterees added the enhancement New feature or request label Dec 4, 2024
@hawksight
Copy link

Some experimental code the potentially resolve the issue: master...aidy:terraform-provider-venafi:pkcs12_data

Does so by providing a pkcs12_data input to the provider as an alternative to the filepath option currently supported.

@marcos-albornoz
Copy link
Contributor

marcos-albornoz commented Dec 9, 2024

The code looks good, but it's missing to add the files cert.p12 and cert-legacy.p12 in order to get the added unit test working successfully... Also it's missing the unit test to evaluate the code logic added in the func providerConfigure()

@aidy
Copy link

aidy commented Dec 11, 2024

The code looks good, but it's missing to add the files cert.p12 and cert-legacy.p12 in order to get the added unit test working successfully...

Those files are present in the diff that @hawksight provided. That unit test is pending being added as part of #152

@hawksight
Copy link

Screenshot 2024-12-11 at 10 56 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants