-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to get the same resolution #25
Comments
there's resolution restrictions in Line 64 in 80ffaa3
you can comment it to obtain your target resolution. |
Thanks @hejingwenhejingwen |
it depends on your 'up_scale'. |
What do i need to set the up_scale to in order to get my 720x480 video to 2560x1440 |
up_scale = 1440/480 or 2560/720 |
Will the black bars be present in the outputted video and we can just crop it out? And if we were to set the upscale to 2560/720 without any black bars then would it stretch things or mess with the resolution of the outputted video |
I mean you obtain 2160x1440 by setting up_scale=3. After venhancer, you add black borders to make it 2560x1440. If you directly set the target resolution with different aspect ratio, the video will be stretched. |
test1.mp4
When i try to enhance the video above from open-sora the target resolution is always set to a max of 1152, 2048
2024-10-14 01:59:38,941 - video_to_video - INFO - input frames length: 102
2024-10-14 01:59:38,941 - video_to_video - INFO - input fps: 24.0
2024-10-14 01:59:38,941 - video_to_video - INFO - target_fps: 24.0
2024-10-14 01:59:39,703 - video_to_video - INFO - input resolution: (720, 1280)
2024-10-14 01:59:39,704 - video_to_video - INFO - target resolution: (1152, 2048)
2024-10-14 01:59:39,704 - video_to_video - INFO - noise augmentation: 250
2024-10-14 01:59:39,704 - video_to_video - INFO - scale s is set to: 8
2024-10-14 01:59:39,834 - video_to_video - INFO - video_data shape: torch.Size([102, 3, 1152, 2048])
I thought the max was 2k or 2560x1440 like the example you provided. If i try to manually set the target height and width I get a memory error with a 80gb H100
The text was updated successfully, but these errors were encountered: