-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] name-non-ascii: Prevents file or directory names with ASCII characters #134
[ADD] name-non-ascii: Prevents file or directory names with ASCII characters #134
Conversation
Functional test: @moylop260 Can you review? |
24ad585
to
dc06ea8
Compare
Could you check the red CI, please? If the error is related with this change create only one commit for both changes But if the error is not related 2 commits separated (same PR since that there is not another PR opened), please |
541c548
to
7321c0d
Compare
7531a97
to
cc008b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 78.09% 80.23% +2.14%
==========================================
Files 4 4
Lines 420 425 +5
==========================================
+ Hits 328 341 +13
+ Misses 92 84 -8 ☔ View full report in Codecov by Sentry. |
I just fixed the CI from #135 This lint should validate that the named of the file is snake_case without accents or special chars I mean: I think the following regex could work but not sure: |
cc008b9
to
ed251be
Compare
ed251be
to
cc970eb
Compare
For record, inspired on https://www.odoo.com/documentation/17.0/es/contributing/development/coding_guidelines.html#file-naming Special thank you to @sebasdrk17 because of take care to report it and @imanie383 complementing extra guidelines info |
Oh, I just noticed that you pushed a new commit. I had come up with this regex:
Which forbids |
Adds a
fail
language hook to validate filenames. This particular hook simply verifies that the filename does not contain spaces, but it can be extended to more general requirements.