Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled StarFold tests #71

Closed
ibbem opened this issue Mar 3, 2023 · 1 comment
Closed

Disabled StarFold tests #71

ibbem opened this issue Mar 3, 2023 · 1 comment
Assignees
@maximilian-glumann
Labels
Good First Issue Low hanging fruits

Comments

@ibbem
Copy link
Collaborator

ibbem commented Mar 3, 2023

Currently, the StarFold tests are disabled because DiffTree.toTextDiff has been removed (see #70). As StarFold is currently unused we have the choice of either fixing the tests or removing StarFold.
@pmbittner
Copy link
Member

pmbittner commented Sep 28, 2023 •
edited
Loading

There is no real use case for StarFold anymore. We used it to try out an idea but it did not work as intended in the end. So we should delete the StartFold class and the corresponding test cases and data (if there is any).

@pmbittner pmbittner added the Good First Issue Low hanging fruits label Sep 28, 2023
@pmbittner pmbittner moved this to Todo in SE-Project WT23/24 Oct 24, 2023
@maximilian-glumann maximilian-glumann mentioned this issue Nov 23, 2023
Merged
pmbittner added a commit that referenced this issue Nov 23, 2023
@pmbittner
Merge pull request #110 from maximilian-glumann/delete-starfold
ab64ce2 
#fixes #71
@pmbittner pmbittner moved this from Todo to Done in SE-Project WT23/24 Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximilian-glumann maximilian-glumann

Labels
Good First Issue Low hanging fruits
Projects
No open projects
SE-Project WT23/24
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximilian-glumann @pmbittner @ibbem