Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to install on removable drive #348

Open
andreacoradi opened this issue Jan 30, 2024 · 7 comments · May be fixed by #411
Open

Option to install on removable drive #348

andreacoradi opened this issue Jan 30, 2024 · 7 comments · May be fixed by #411
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andreacoradi
Copy link

andreacoradi commented Jan 30, 2024 •
edited
Loading

Screenshot from 2024-01-30 20-01-15

I have 2 SATA SSDs: /dev/sda (the one shown in gparted) and /dev/sdb, both using GPT format, and installer can't see them.
It only shows options for my 2 NVME SSDs and my external drive.

PS: using the beta ISO for VanillaOS

Attached lsblk output:
lsblk.txt
@andreacoradi
Copy link
Author

I've tracked down the issue to this piece of code:

vanilla-installer/vanilla_installer/core/disks.py

Lines 193 to 198 in 29f606c

if os.path.isfile("/sys/block/" + disk + "/removable"):
with open("/sys/block/" + disk + "/removable") as f:
removable = int(f.readlines()[0].strip())
if removable == 1:
continue

It seems my SSDs are mounted as removable?
The even stranger thing is that my external drive (/dev/sdc) is not...

@taukakao
Copy link
Member

Hm, we can't really help this if it's just linux reporting incorrect data. How are sda and sdc plugged in?

But this check is weird anyway. There should be an option to install to an external drive regardless.

@andreacoradi
Copy link
Author

I found out that it was related to a setting in the BIOS called "SATA Hotplug enable". If I disable this it's no longer considered removable.
I agree with the feeling that maybe this check is unnecessary

@taukakao
Copy link
Member

taukakao commented Feb 2, 2024

I don't think it's unnecessary.
I think there should be an option "Install on removable drive"

@taukakao taukakao changed the title Can't install on SATA SSD Option to install on removable drive Feb 10, 2024
@taukakao taukakao mentioned this issue Feb 10, 2024
Closed
@trymeouteh
Copy link

Would like to see this as an option with the ability to also encrypt the installation with full disk encryption.

@muhdsalm
Copy link
Contributor

Is installing on a removable drive supported by Vanilla OS? (I'm talking about stuff like FSGuard - would that still work even if the drive was removable?)

@taukakao
Copy link
Member

I don't see a reason why it wouldn't work.

@taukakao taukakao added the enhancement New feature or request label Apr 23, 2024
@taukakao taukakao mentioned this issue Apr 23, 2024
Closed
@taukakao taukakao added the good first issue Good for newcomers label Jul 6, 2024
muhdsalm added a commit to muhdsalm/vanilla-installer that referenced this issue Aug 3, 2024
@muhdsalm
feat[Vanilla-OS#348: Option to install on removable drive
209b6c8
@muhdsalm muhdsalm linked a pull request Aug 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat[#348]: Option to install on removable drive muhdsalm/vanilla-installer
4 participants
@andreacoradi @trymeouteh @taukakao @muhdsalm