Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key pressed events keep coming even when the controller is off in 4.24.2 #116

Open
muchcharles opened this issue Jan 30, 2020 · 8 comments

Comments

@muchcharles
Copy link

If the controller is turned off while a key is pressed, unreal will keep firing key events for it even if the controller was turned off before Unreal launched. I got this first with grip events on index but also tested with the A button (it must have first happened due to gripping while turning the controller off, which can be hard not to do).

I saw this on both SteamVR 1.10.7 and 1.10.8 (haven't tried stable yet).

4.24.2 seems to have added some logic around triggering key repeat events that wasn't there in 4.24.1 and that may be part of why it started showing up. But it may also be that steamvr should be clearing out the controller pressed state when a controller is turned off, because it does seem to leave the stuff set and bActive true:

image

@1runeberg
Copy link
Contributor

Hi @muchcharles - Unable to replicate this in 1.9.16 & 1.10.8 - which controller are you using?

@muchcharles
Copy link
Author

muchcharles commented Jan 31, 2020

Knuckles DV. I just got a clean engine debug build from tag 4.24-release without any of my branch and I'm still seeing it. I held down the A button as I turned off the controller with steamvr running, and launched UE4 afterwards:

image

(screenshot got cropped a bit, the MessageHandler->OnControllerButtonPressed line with two horizontal grey lines is where things are in the debugger)

This was in the stock engine VR template.

@1runeberg
Copy link
Contributor

1runeberg commented Feb 1, 2020

Hi @muchcharles - Is this test project just the standard VR Template?

Can you uncomment those two UE_LOGS and send me the result you are getting? Also your SteamVR System Report with logs that were being generated at the same time as when you are observing the repeats) all to [email protected] please.

Thanks,
Rune

@muchcharles
Copy link
Author

Sure, I'll mail you a system report taken while running it. This is what shows when those logs are uncommented

[2020.02.01-03.49.11:460][ 1]LogTemp: Warning: Handle /actions/main/in/TeleportLeft KeyX ValveIndex_Left_A_Click Value 1 Changed 0 UpdateTime -34448.824219 [2020.02.01-03.49.11:461][ 1]LogTemp: Warning: Handle /actions/main/in/GrabLeft KeyX MixedReality_Left_Trigger_Click Value 1 Changed 0 UpdateTime -34438.761719 [2020.02.01-03.49.11:703][ 4]LogTemp: Warning: [REPEAT] Handle /actions/main/in/TeleportLeft KeyX ValveIndex_Left_A_Click Value 1 Changed 0 UpdateTime -34449.066406 [2020.02.01-03.49.11:704][ 4]LogTemp: Warning: [REPEAT] Handle /actions/main/in/GrabLeft KeyX MixedReality_Left_Trigger_Click Value 1 Changed 0 UpdateTime -34439.003906 [2020.02.01-03.49.11:807][ 11]LogTemp: Warning: [REPEAT] Handle /actions/main/in/TeleportLeft KeyX ValveIndex_Left_A_Click Value 1 Changed 0 UpdateTime -34449.171875 [2020.02.01-03.49.11:808][ 11]LogTemp: Warning: [REPEAT] Handle /actions/main/in/GrabLeft KeyX MixedReality_Left_Trigger_Click Value 1 Changed 0 UpdateTime -34439.109375 [2020.02.01-03.49.11:939][ 18]LogTemp: Warning: [REPEAT] Handle /actions/main/in/TeleportLeft KeyX ValveIndex_Left_A_Click Value 1 Changed 0 UpdateTime -34449.300781

@muchcharles
Copy link
Author

One thing you might make sure of in reproducing it is that the dashboard doesn't open, sometimes when turning off the controller that seems to happen and could maybe consume the inputs.

@1runeberg
Copy link
Contributor

thanks. please make sure you send me the full UE LOG as well :)

Cheers,
Rune

@muchcharles
Copy link
Author

Looks like a couple people have reported this recently for steamvr in general:

ValveSoftware/openvr#1296

@1runeberg
Copy link
Contributor

was tricky to replicate as turning off the controller for Index at least is difficult while a button is pressed. but it appears if you press and unpress while turning it off then subsequent shutdowns with a press works.

still investigating this however, but it does point to a potential steamvr issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants