Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor classes #14

Open
tknapen opened this issue Dec 8, 2021 · 2 comments
Open

Refactor classes #14

tknapen opened this issue Dec 8, 2021 · 2 comments
Assignees
@tknapen @niklas-mueller
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tknapen
Copy link
Contributor

tknapen commented Dec 8, 2021

Classes are not used optimally now. Need to change the code to fix this.
@tknapen tknapen added enhancement New feature or request help wanted Extra attention is needed labels Dec 8, 2021
@tknapen tknapen self-assigned this Dec 8, 2021
@tknapen
Copy link
Contributor Author

tknapen commented Dec 8, 2021

@RonvdKlundert, @marcoaqil, @gjheij, @iverissimo, @niklas-vu, @N-HEDGER, @sumiyaabdi
We should discuss this in our meeting on the 20th.

@tknapen
Copy link
Contributor Author

tknapen commented Jan 26, 2022

  • Model and Fitter classes would preferably be ABCs.
  • The most-used piece of code in prfpy now is np.newaxis, because return_prediction isn't returning a single prediction anymore. Needs fixing.
  • Separate out different models into different files: clearer package structure

@niklas-mueller niklas-mueller self-assigned this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tknapen tknapen

@niklas-mueller niklas-mueller

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tknapen @niklas-mueller