forked from javamachr/quest-sidenoder
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add commit-lint and Commitizen #37
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeRatcliffe
changed the title
build: Enable lint-staged
build: Add commit-lint and Commitizen
Sep 15, 2024
MikeRatcliffe
force-pushed
the
add-commitlint
branch
from
September 15, 2024 14:20
5ca0f2c
to
e69556f
Compare
This was referenced Sep 15, 2024
Closed
Closed
MikeRatcliffe
force-pushed
the
add-commitlint
branch
from
September 17, 2024 09:49
e69556f
to
3ee3bfd
Compare
MikeRatcliffe
force-pushed
the
add-commitlint
branch
from
September 17, 2024 12:21
3ee3bfd
to
9e59619
Compare
MikeRatcliffe
force-pushed
the
add-commitlint
branch
from
September 17, 2024 12:40
9e59619
to
50ea194
Compare
fix: Battery not displayed properly build: Add eslint
MikeRatcliffe
force-pushed
the
add-commitlint
branch
from
September 17, 2024 13:05
50ea194
to
4bda883
Compare
MikeRatcliffe
force-pushed
the
add-commitlint
branch
2 times, most recently
from
September 17, 2024 13:46
dab2c8c
to
68feb01
Compare
MikeRatcliffe
force-pushed
the
add-commitlint
branch
from
September 17, 2024 13:55
68feb01
to
4bab65b
Compare
Adds GitHub Actions workflow for automated releases, including: - Build for multiple OSs: - macOs (Universal `dmg` for both Intel & M1) - Windows `exe` - Linux: - `AppImage` - `deb` - `rpm` - Changelog is automatically generated when a version number tag is added to a commit e.g. `v0.9.2`. This streamlines the release process and ensures consistent releases across all platforms. Usage: 1. Update version number in `package.json`. 2. ``` git commit -m "Release v0.9.2" git tag v0.9.2 # The version number must be in the format `v1.2.3`. git push --force --tags ``` 3. That's it... a release will be automatically generated along with conventional commit messages and installation packages for each platform. To ensure we pick up all changes we should probably add the conventional commits pre-commit hook to ensure commit messages contain the required `fix`, `feat` etc.
MikeRatcliffe
force-pushed
the
add-commitlint
branch
from
September 17, 2024 13:57
4bab65b
to
45c8222
Compare
fix: Properly close `adb` and `rclone` on exit Fixes VRPirates#34 Cleanly closes `adb` and `rclone` connections when the application exits, ensuring resources are freed and preventing potential issues. This addresses a previous oversight where these connections weren't properly closed, potentially leading to resource leaks or unexpected behavior. Even though we free up the adb connection we don't close the server because other programs may be using the connection.
MikeRatcliffe
force-pushed
the
add-commitlint
branch
from
September 17, 2024 13:59
45c8222
to
a31a4b6
Compare
In order for the automatic release process VRPirates#32 to work we need to ensure that we always use conventional commits in order for the changelog to be generated correctly. This patch ensures that this is the case.
MikeRatcliffe
force-pushed
the
add-commitlint
branch
from
September 17, 2024 14:00
a31a4b6
to
7c699b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
Pull request order:
#18 -> #19 -> #20 -> #21 -> #22 -> #29 -> #37
In order for the automatic release process #32 to work we need to ensure that we always use conventional commits in order for the changelog to be generated correctly. This patch ensures that this is the case.