Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for passing options to kernel::loadModule() #802

Open
IgnoreWarnings opened this issue Jul 29, 2024 · 1 comment
Open

Add support for passing options to kernel::loadModule() #802

IgnoreWarnings opened this issue Jul 29, 2024 · 1 comment
Assignees
@IgnoreWarnings
Labels
enhancement New feature or request

Comments

@IgnoreWarnings
Copy link
Collaborator

IgnoreWarnings commented Jul 29, 2024 •
edited by stv0g
Loading

Because of the missing reset_required=0 the module loading in Kernel doesn't work without reboot.

https://github.com/VILLASframework/node/blob/5f44e16ced1ed7dda03e271e538984903e1eb075/common/lib/kernel/kernel.cpp#L142C1-L149C48
@IgnoreWarnings IgnoreWarnings added the bug Something isn't working label Jul 29, 2024
@IgnoreWarnings IgnoreWarnings changed the title Bug: Kernel LoadModule function isnt working in a thread Bug: Kernel LoadModule function isnt working Jul 29, 2024
@IgnoreWarnings IgnoreWarnings removed the bug Something isn't working label Jul 29, 2024
@IgnoreWarnings IgnoreWarnings added the bug Something isn't working label Jul 29, 2024
@IgnoreWarnings IgnoreWarnings self-assigned this Jul 29, 2024
@IgnoreWarnings IgnoreWarnings changed the title Bug: Kernel LoadModule function isnt working Bug: Module "vfio" cannot be loaded Jul 31, 2024
@IgnoreWarnings IgnoreWarnings changed the title Bug: Module "vfio" cannot be loaded Bug: Module "vfio" cannot be loaded on Miob Jul 31, 2024
@IgnoreWarnings IgnoreWarnings changed the title Bug: Module "vfio" cannot be loaded on Miob Bug: Kernel::loadModule isnt working. Jul 31, 2024
@IgnoreWarnings IgnoreWarnings changed the title Bug: Kernel::loadModule isnt working. Bug: Kernel::loadModule isnt working Jul 31, 2024
@IgnoreWarnings IgnoreWarnings changed the title Bug: Kernel::loadModule isnt working Bug: Kernel::loadModule isnt working because of missing reset_required=0 Jul 31, 2024
@stv0g stv0g changed the title Bug: Kernel::loadModule isnt working because of missing reset_required=0 Add support for passing options to kernel::loadModule() Jul 31, 2024
@stv0g stv0g added the enhancement New feature or request label Jul 31, 2024
@stv0g
Copy link
Contributor

stv0g commented Jul 31, 2024

This is not a bug, but requires and enhancement to load_module(). We should allow passing additional module options to it. Maybe as a vararg function, which we simple pass through?

@IgnoreWarnings IgnoreWarnings removed the bug Something isn't working label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgnoreWarnings IgnoreWarnings

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stv0g @IgnoreWarnings