Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gitignore #4

Open
ocombe opened this issue Oct 26, 2015 · 10 comments
Open

Use gitignore #4

ocombe opened this issue Oct 26, 2015 · 10 comments
Assignees

Comments

@ocombe
Copy link

ocombe commented Oct 26, 2015

It would be nice if the generator could use the gitignore file and not copy these ignored files into the resource folders :)

@vrunoa
Copy link
Member

vrunoa commented Oct 26, 2015

I believe this should be an implementation on the electron-packager lib, since electron-packager-interactive it just a wrapper for this module.
Maybe it's already implemented and i'm missing something, let me check.

@ocombe
Copy link
Author

ocombe commented Oct 26, 2015

The thing with electron packager is that you get to set the "ignore" parameter, but you cannot do that with the interactive command :(

@vrunoa vrunoa self-assigned this Oct 26, 2015
@vrunoa
Copy link
Member

vrunoa commented Oct 26, 2015

Oh, then I'll add an implementation to the ignore param. I'll let you know when it's ready.

@ocombe
Copy link
Author

ocombe commented Oct 26, 2015

Nice :)
I'm just afraid that it will be a bit boring to type all the files that you want to ignore every time, that's why I suggested to use the gitignore file

@vrunoa
Copy link
Member

vrunoa commented Oct 26, 2015

Inside the .gitignore is the node_modules folder which is quite important for the electron app. Maybe we should create another convention file like .electronignore to set the files to ignore or avoid to add this folder when reading the .gitignore. Whats your opinion ? Wonder what @maxogden thinks ?

@ocombe
Copy link
Author

ocombe commented Oct 26, 2015

Hmm yeah, didn't think of node_modules folder...
But if we end up making an electronignore file, why not have a config file, and then why not use electron packager instead of the interactive one :)

@vrunoa
Copy link
Member

vrunoa commented Oct 26, 2015

Good point. In that case, maybe the better solution would be to create a new node cli to take all the params from from a json file. And to this module just add the implementation to accept the ignore param

@vrunoa
Copy link
Member

vrunoa commented Oct 27, 2015

hey @ocombe have you check grunt-electron ? With that module you can set every param as a grunt task. It's a closer approach to having a config file.

@ocombe
Copy link
Author

ocombe commented Oct 27, 2015

Well I'm using electron-packager now, with a gulp task that I made myself :)

@vrunoa
Copy link
Member

vrunoa commented Oct 27, 2015

Cool. I will add the possibility to set the ignore param as a simple input, but it will only accept regex as electron-packager does it.
There's also a new release of the module with the icon option and automatically adding the output folder to the ignore param.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants