use forked node-speaker implementation with warning log removed #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Why not include the library into |
|
This is a good PR but we should probably ingest the change into the monorepo rather than depending on a |
|
|
will have to fix build deps, moving to draft for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the buffer underflow warning originating from the node-speaker's coreaudio.c implementation.
The update includes using our own forked repo with only the warning code line being commented out, the forked Repo is found here:
https://github.com/UpstreetAI/node-speaker
Some package-lock updates are not directly associated with this update as they were integrated by running npm i before updating the speaker dep in package.json. (mostly ora package updates)