-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
126 connect footer to strapi #145
base: main
Are you sure you want to change the base?
Conversation
… should not be an array
…e and images are not visible
…was lost in strapi
…he pngs arent showing on the footer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for decoupling the footer links from the header links, +1! Same for nullable
Be aware there's a mismatch between required fields in Strapi vs required fields in the zod schema, here's an example:
It means that Younite exec (who won't understand why their site is broken) can input invalid data into Strapi and crash their site. Make sure the zod and strapi fields are either both required or both optional (and have a good think about what should be required and what shouldn't... e.g. logos should probably be required since you can't display anything without a picture! But maybe the the URL is optional... or maybe you decide to make it mandatory since it's 'an error' if not every sponsor logo actually goes to a sponsor's site. It's an important design consideration I think you'd get a lot of benefit practicing here :D)
Also, just keep in mind it's the Younite exec who'll be using this Strapi CMS, not us (otherwise we'd not bother with it oml). Choose names that make sense to the clients, not us - maybe topFooter should be logos? younite should be copyrightText? (if they rebrand that field might not make a lot of sense haha)
You're really close to pushing out one of the most technical tickets anyone on the team worked on this year so keep at it :D
Context
Closes
What Changed?
How To Review
Notes