Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRONTEND] Put faded lodge image on about page #745

Open
6 tasks
choden-dev opened this issue Aug 6, 2024 · 0 comments
Open
6 tasks

[FRONTEND] Put faded lodge image on about page #745

choden-dev opened this issue Aug 6, 2024 · 0 comments
Assignees
@Kunalbskr
Labels
frontend relating to code in the /client directory

Comments

@choden-dev
Copy link
Member

choden-dev commented Aug 6, 2024 •
edited by Kunalbskr
Loading

Is your feature request related to a problem? Please describe.

Image

The about page is located at client\src\app\about\page.tsx due to the structure of next.js' app router

BEFORE MERGING

  • Storybooks created where possible
  • Tested with nock if data fetching
  • Tests written for critical interactions
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@choden-dev choden-dev added the frontend relating to code in the /client directory label Aug 6, 2024
@Kunalbskr Kunalbskr self-assigned this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kunalbskr Kunalbskr

Labels
frontend relating to code in the /client directory
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

745-frontend-put-faded-lodge-image-on-about-page UoaWDCC/uasc-web
2 participants
@choden-dev @Kunalbskr