Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKEND] Change booking dates endpoints #727

Open
7 tasks
jeffplays2005 opened this issue Jul 30, 2024 · 0 comments
Open
7 tasks

[BACKEND] Change booking dates endpoints #727

jeffplays2005 opened this issue Jul 30, 2024 · 0 comments
Assignees
@zlkaede11
Labels
backend relating to code in the /server directory
Milestone
Handover

Comments

@jeffplays2005
Copy link
Contributor

This is not an urgent ticket

Would be a good edit to make the endpoints before handover:
POST /bookings/make-dates-available/unavailable -> PATCH /admin/bookings/dates

BEFORE MERGING

  • Integration test written for services
  • Schemas annotated if adding new models
  • Code generation run (hint: yarn workspace server tsoa spec-and-routes)
  • Appropriate mocks created where possible
  • PR Reviewed (For non-trivial changes)
  • Changes tested after rebasing on master or merging in master (hint: git fetch origin master:master, then git rebase master or git merge master)
  • All required PR checks passing
@jeffplays2005 jeffplays2005 added the backend relating to code in the /server directory label Jul 30, 2024
@jeffplays2005 jeffplays2005 added this to the Handover milestone Jul 30, 2024
@zlkaede11 zlkaede11 self-assigned this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zlkaede11 zlkaede11

Labels
backend relating to code in the /server directory
Projects
None yet
Milestone
Handover
Development

No branches or pull requests
2 participants
@jeffplays2005 @zlkaede11