Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created page for blocking non-members from bookings #719

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Created page for blocking non-members from bookings #719

wants to merge 14 commits into from

Conversation

Kartik-M24
Copy link
Contributor

This isn't complete yet just had a question cause I couldn't center the div

@Kartik-M24 Kartik-M24 linked an issue Jul 29, 2024 that may be closed by this pull request
[FRONTEND] Implement blurred bookings page for non logged in users #524
Open
6 tasks
@Kartik-M24
Copy link
Contributor Author

Kartik-M24 commented Jul 29, 2024 •
edited
Loading

image

image

I think the width is a bit off for this, but if I increase padding it messes up the small mobile version

@Kartik-M24 Kartik-M24 force-pushed the 524-frontend-implement-blurred-bookings-page-for-non-logged-in-users branch from 69bfec5 to d0ab545 Compare July 31, 2024 11:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 2fe1ebb):

https://uasc-ceebc--pr719-524-frontend-impleme-1k2gzbtz.web.app

(expires Mon, 19 Aug 2024 00:02:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa

@Kartik-M24 Kartik-M24 force-pushed the 524-frontend-implement-blurred-bookings-page-for-non-logged-in-users branch from 3203360 to 105b16f Compare August 2, 2024 05:37
@Kartik-M24 Kartik-M24 requested a review from choden-dev August 2, 2024 05:43
choden-dev
choden-dev reviewed Aug 2, 2024
View reviewed changes
client/src/components/generic/SignUpNotif/SignUpNotif.tsx Outdated Show resolved Hide resolved
server/package.json Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
client/package.json Outdated Show resolved Hide resolved
choden-dev
choden-dev reviewed Aug 3, 2024
View reviewed changes
Copy link
Member

@choden-dev choden-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you check it on actual app you'll see that the thing isn't centered, it would be better for you to let it stretch the whole width:

image

@Kartik-M24
Copy link
Contributor Author

The prechecks said to run yarn, after doing so the only file that updates is yarn.lock which I had deleted, what do you recommend I do?

@choden-dev
Copy link
Member

The prechecks said to run yarn, after doing so the only file that updates is yarn.lock which I had deleted, what do you recommend I do?

You shouldn't delete yarn.lock as that tells yarn what it needs to download.

Instead what you should do is revert it to the master version (make sure you have the latest master) with git checkout master yarn.lock

choden-dev
choden-dev reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@choden-dev choden-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

doesn't appear to match design (not centered etc)

server/package.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes here

client/package.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

yarn.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choden-dev choden-dev choden-dev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FRONTEND] Implement blurred bookings page for non logged in users
2 participants
@Kartik-M24 @choden-dev