Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake fails to build because of order of building dependencies #16

Open
pefribeiro opened this issue Aug 30, 2023 · 0 comments
Open

CMake fails to build because of order of building dependencies #16

pefribeiro opened this issue Aug 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@pefribeiro
Copy link

Currently, there is an embedded assumption in the generate CMake wrt convert, that can fail builds when the dependency has not finished producing the desired C++ header files. This means, in particular, that building against a Python node fails. The following needs changing:

if (NOT TARGET convert)
add_library(convert
../convert/convert.cpp
)
endif()

So that it becomes:

if (NOT TARGET convert)
    add_library(convert
        ../convert/convert.cpp
    )
    add_dependencies(convert
        TARGET_NOTE_generate_messages_cpp
    )
endif()

TARGET_NOTE needs to pull the name of the target test node. I don't think the template is called with this info, but only a bunch of dependencies. Current workaround is to change this manually for a specific example.

@pefribeiro pefribeiro added the bug Something isn't working label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant