You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, the tester generates only one callback (and ROS subscription) for input acceptance. Discussion with @pefribeiro suggests we may need to generalise this when we start accepting multiple inputs, so that we can understand which input has been received.
Some relevant bits of code that might need to change are as follows. Generally, wherever we have .Transitions.HasIn, we'd need to range over the input channels (.Transitions.In should work, since we hopefully don't need to consider the possibility of the system acknowledging inputs we don't control, unlike the situation with #14 and output transitions).
Right now, the tester generates only one callback (and ROS subscription) for input acceptance. Discussion with @pefribeiro suggests we may need to generalise this when we start accepting multiple inputs, so that we can understand which input has been received.
Some relevant bits of code that might need to change are as follows. Generally, wherever we have
.Transitions.HasIn
, we'd need to range over the input channels (.Transitions.In
should work, since we hopefully don't need to consider the possibility of the system acknowledging inputs we don't control, unlike the situation with #14 and output transitions).Here (callback prototypes):
rtcg/internal/gen/cpp/embed/templates/base/stm.cpp.tmpl
Lines 23 to 25 in a10b169
And here (callback definitions; maybe we can get rid of
InMerged
):rtcg/internal/gen/cpp/embed/templates/base/stm.cpp.tmpl
Lines 114 to 122 in a10b169
And, in the animator, here (generalise to one menu item per input channel?):
rtcg/internal/gen/cpp/embed/templates/animate/main_body.cpp.tmpl
Lines 37 to 40 in a10b169
And, in ROS, here (generalise to one subscriber per input channel?):
rtcg/internal/gen/cpp/embed/templates/ros/main.cpp.tmpl
Lines 60 to 62 in a10b169
The situation with the input delay callbacks may also need some reworking, but I'm not yet sure how.
The text was updated successfully, but these errors were encountered: