Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sor): support routing on unichain mainnet #766

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(sor): support routing on unichain mainnet #766

wants to merge 6 commits into from

Conversation

xrsv
Copy link
Contributor

@xrsv xrsv commented Nov 21, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Support routing in SOR for Unichain Mainnet.
    Also Renames ASTROCHAIN_SEPOLIA to UNICHAIN_SEPOLIA

  • Other information:
    Pending

@xrsv xrsv requested a review from a team as a code owner November 21, 2024 20:46
@xrsv xrsv requested review from jsy1218 and cgkol November 21, 2024 20:46
@socket-security Socket Security
Copy link

socket-security bot commented Nov 21, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@uniswap/[email protected] environment Transitive: network +27 3.02 MB uniswap-labs-service-account
npm/@uniswap/[email protected] environment +14 1.36 MB uniswap-labs-service-account
npm/@uniswap/[email protected] environment +5 94.3 MB uniswap-labs-service-account
npm/@uniswap/[email protected] environment +17 1.1 MB uniswap-labs-service-account
npm/@uniswap/[email protected] environment Transitive: network +33 4.88 MB uniswap-labs-service-account
npm/@uniswap/[email protected] environment +15 1.68 MB uniswap-labs-service-account

🚮 Removed packages: npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected]

View full report↗︎

xrsv
xrsv commented Nov 21, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@xrsv xrsv mentioned this pull request Nov 21, 2024
Open
cgkol
cgkol reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge, can we test that the quotes are returned correctly locally with real on chain data?

src/providers/on-chain-quote-provider.ts Outdated Show resolved Hide resolved
@graphite-app graphite-app bot requested review from a team and cgkol November 25, 2024 17:11
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 25, 2024

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (11/25/24)

3 reviewers were added and 1 assignee was added to this PR based on 's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsy1218 jsy1218 Awaiting requested review from jsy1218

@cgkol cgkol Awaiting requested review from cgkol

At least 1 approving review is required to merge this pull request.

Assignees

@xrsv xrsv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrsv @cgkol