From 44ce99e4058d3a0b4085580a9e9ccf86b1911e99 Mon Sep 17 00:00:00 2001
From: jsy1218 <91580504+jsy1218@users.noreply.github.com>
Date: Wed, 3 Jul 2024 05:51:23 -0700
Subject: [PATCH 1/3] chore(v3-sdk): annotate FACTORY_ADDRESS as deprecated

---
 .idea/workspace.xml | 109 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 109 insertions(+)
 create mode 100644 .idea/workspace.xml

diff --git a/.idea/workspace.xml b/.idea/workspace.xml
new file mode 100644
index 000000000..0069c86ba
--- /dev/null
+++ b/.idea/workspace.xml
@@ -0,0 +1,109 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="AutoImportSettings">
+    <option name="autoReloadType" value="SELECTIVE" />
+  </component>
+  <component name="ChangeListManager">
+    <list default="true" id="622c4fdf-e1f9-44c4-ac1e-dd7a5d3f8c66" name="Changes" comment="" />
+    <option name="SHOW_DIALOG" value="false" />
+    <option name="HIGHLIGHT_CONFLICTS" value="true" />
+    <option name="HIGHLIGHT_NON_ACTIVE_CHANGELIST" value="false" />
+    <option name="LAST_RESOLUTION" value="IGNORE" />
+  </component>
+  <component name="Git.Settings">
+    <option name="RECENT_GIT_ROOT_PATH" value="$PROJECT_DIR$" />
+  </component>
+  <component name="MarkdownSettingsMigration">
+    <option name="stateVersion" value="1" />
+  </component>
+  <component name="ProjectColorInfo">{
+  &quot;customColor&quot;: &quot;&quot;,
+  &quot;associatedIndex&quot;: 2
+}</component>
+  <component name="ProjectId" id="2fbcRPM0cWIeeF1gZZ9lKRB0QGv" />
+  <component name="ProjectViewState">
+    <option name="hideEmptyMiddlePackages" value="true" />
+    <option name="showLibraryContents" value="true" />
+  </component>
+  <component name="PropertiesComponent"><![CDATA[{
+  "keyToString": {
+    "Jest.#computePoolAddress.executor": "Run",
+    "Jest.#computePoolAddress.should correctly compute zkevm pool address.executor": "Run",
+    "Jest.computePoolAddress.test.ts.executor": "Run",
+    "RunOnceActivity.OpenProjectViewOnStart": "true",
+    "RunOnceActivity.ShowReadmeOnStart": "true",
+    "git-widget-placeholder": "jsy1218/zora-blast-weth9",
+    "last_opened_file_path": "/Users/siyu.jiang/workspace/sdks",
+    "node.js.detected.package.eslint": "true",
+    "node.js.detected.package.tslint": "true",
+    "node.js.selected.package.eslint": "(autodetect)",
+    "node.js.selected.package.tslint": "(autodetect)",
+    "nodejs.jest.jest_package": "/Users/siyu.jiang/workspace/sdks/node_modules/jest",
+    "nodejs_package_manager_path": "yarn",
+    "ts.external.directory.path": "/Users/siyu.jiang/workspace/sdks/node_modules/typescript/lib",
+    "vue.rearranger.settings.migration": "true"
+  }
+}]]></component>
+  <component name="RunManager" selected="Jest.#computePoolAddress.should correctly compute zkevm pool address">
+    <configuration name="#computePoolAddress" type="JavaScriptTestRunnerJest" temporary="true" nameIsGenerated="true">
+      <node-interpreter value="project" />
+      <jest-package value="$PROJECT_DIR$/node_modules/jest" />
+      <working-dir value="$PROJECT_DIR$/sdks/v3-sdk" />
+      <envs />
+      <scope-kind value="SUITE" />
+      <test-file value="$PROJECT_DIR$/sdks/v3-sdk/src/utils/computePoolAddress.test.ts" />
+      <test-names>
+        <test-name value="#computePoolAddress" />
+      </test-names>
+      <method v="2" />
+    </configuration>
+    <configuration name="#computePoolAddress.should correctly compute zkevm pool address" type="JavaScriptTestRunnerJest" temporary="true" nameIsGenerated="true">
+      <node-interpreter value="project" />
+      <jest-package value="$PROJECT_DIR$/node_modules/jest" />
+      <working-dir value="$PROJECT_DIR$/sdks/v3-sdk" />
+      <envs />
+      <scope-kind value="TEST" />
+      <test-file value="$PROJECT_DIR$/sdks/v3-sdk/src/utils/computePoolAddress.test.ts" />
+      <test-names>
+        <test-name value="#computePoolAddress" />
+        <test-name value="should correctly compute zkevm pool address" />
+      </test-names>
+      <method v="2" />
+    </configuration>
+    <configuration name="computePoolAddress.test.ts" type="JavaScriptTestRunnerJest" temporary="true" nameIsGenerated="true">
+      <node-interpreter value="project" />
+      <jest-package value="$PROJECT_DIR$/node_modules/jest" />
+      <working-dir value="$PROJECT_DIR$/sdks/v3-sdk" />
+      <envs />
+      <scope-kind value="TEST_FILE" />
+      <test-file value="$PROJECT_DIR$/sdks/v3-sdk/src/utils/computePoolAddress.test.ts" />
+      <method v="2" />
+    </configuration>
+    <recent_temporary>
+      <list>
+        <item itemvalue="Jest.#computePoolAddress.should correctly compute zkevm pool address" />
+        <item itemvalue="Jest.computePoolAddress.test.ts" />
+        <item itemvalue="Jest.#computePoolAddress" />
+      </list>
+    </recent_temporary>
+  </component>
+  <component name="SpellCheckerSettings" RuntimeDictionaries="0" Folders="0" CustomDictionaries="0" DefaultDictionary="application-level" UseSingleDictionary="true" transferred="true" />
+  <component name="TaskManager">
+    <task active="true" id="Default" summary="Default task">
+      <changelist id="622c4fdf-e1f9-44c4-ac1e-dd7a5d3f8c66" name="Changes" comment="" />
+      <created>1714073209620</created>
+      <option name="number" value="Default" />
+      <option name="presentableId" value="Default" />
+      <updated>1714073209620</updated>
+      <workItem from="1714073210785" duration="7575000" />
+      <workItem from="1714651076530" duration="14000" />
+      <workItem from="1716238723141" duration="564000" />
+      <workItem from="1716321028710" duration="19043000" />
+      <workItem from="1718295734001" duration="35704000" />
+    </task>
+    <servers />
+  </component>
+  <component name="TypeScriptGeneratedFilesManager">
+    <option name="version" value="3" />
+  </component>
+</project>
\ No newline at end of file

From 4a782abea4f9b15aac921f5276862e2bca69d3c4 Mon Sep 17 00:00:00 2001
From: jsy1218 <91580504+jsy1218@users.noreply.github.com>
Date: Wed, 3 Jul 2024 05:54:05 -0700
Subject: [PATCH 2/3] chore(v3-sdk): annotate FACTORY_ADDRESS as deprecated

---
 sdks/v3-sdk/src/constants.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sdks/v3-sdk/src/constants.ts b/sdks/v3-sdk/src/constants.ts
index 086ccd1a5..776db6be8 100644
--- a/sdks/v3-sdk/src/constants.ts
+++ b/sdks/v3-sdk/src/constants.ts
@@ -1,5 +1,8 @@
 import { ChainId } from '@uniswap/sdk-core'
 
+/**
+ * @deprecated use V3_CORE_FACTORY_ADDRESSES from sdk-core instead
+ */
 export const FACTORY_ADDRESS = '0x1F98431c8aD98523631AE4a59f267346ea31F984'
 
 export const ADDRESS_ZERO = '0x0000000000000000000000000000000000000000'

From 5b1d5756b39b180ad62f49f541a27704f5695549 Mon Sep 17 00:00:00 2001
From: jsy1218 <91580504+jsy1218@users.noreply.github.com>
Date: Wed, 10 Jul 2024 00:10:46 +0200
Subject: [PATCH 3/3] remove .idea artifact

---
 .idea/workspace.xml    | 109 -----------------------------------------
 sdks/v3-sdk/.gitignore |   5 +-
 2 files changed, 4 insertions(+), 110 deletions(-)
 delete mode 100644 .idea/workspace.xml

diff --git a/.idea/workspace.xml b/.idea/workspace.xml
deleted file mode 100644
index 0069c86ba..000000000
--- a/.idea/workspace.xml
+++ /dev/null
@@ -1,109 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project version="4">
-  <component name="AutoImportSettings">
-    <option name="autoReloadType" value="SELECTIVE" />
-  </component>
-  <component name="ChangeListManager">
-    <list default="true" id="622c4fdf-e1f9-44c4-ac1e-dd7a5d3f8c66" name="Changes" comment="" />
-    <option name="SHOW_DIALOG" value="false" />
-    <option name="HIGHLIGHT_CONFLICTS" value="true" />
-    <option name="HIGHLIGHT_NON_ACTIVE_CHANGELIST" value="false" />
-    <option name="LAST_RESOLUTION" value="IGNORE" />
-  </component>
-  <component name="Git.Settings">
-    <option name="RECENT_GIT_ROOT_PATH" value="$PROJECT_DIR$" />
-  </component>
-  <component name="MarkdownSettingsMigration">
-    <option name="stateVersion" value="1" />
-  </component>
-  <component name="ProjectColorInfo">{
-  &quot;customColor&quot;: &quot;&quot;,
-  &quot;associatedIndex&quot;: 2
-}</component>
-  <component name="ProjectId" id="2fbcRPM0cWIeeF1gZZ9lKRB0QGv" />
-  <component name="ProjectViewState">
-    <option name="hideEmptyMiddlePackages" value="true" />
-    <option name="showLibraryContents" value="true" />
-  </component>
-  <component name="PropertiesComponent"><![CDATA[{
-  "keyToString": {
-    "Jest.#computePoolAddress.executor": "Run",
-    "Jest.#computePoolAddress.should correctly compute zkevm pool address.executor": "Run",
-    "Jest.computePoolAddress.test.ts.executor": "Run",
-    "RunOnceActivity.OpenProjectViewOnStart": "true",
-    "RunOnceActivity.ShowReadmeOnStart": "true",
-    "git-widget-placeholder": "jsy1218/zora-blast-weth9",
-    "last_opened_file_path": "/Users/siyu.jiang/workspace/sdks",
-    "node.js.detected.package.eslint": "true",
-    "node.js.detected.package.tslint": "true",
-    "node.js.selected.package.eslint": "(autodetect)",
-    "node.js.selected.package.tslint": "(autodetect)",
-    "nodejs.jest.jest_package": "/Users/siyu.jiang/workspace/sdks/node_modules/jest",
-    "nodejs_package_manager_path": "yarn",
-    "ts.external.directory.path": "/Users/siyu.jiang/workspace/sdks/node_modules/typescript/lib",
-    "vue.rearranger.settings.migration": "true"
-  }
-}]]></component>
-  <component name="RunManager" selected="Jest.#computePoolAddress.should correctly compute zkevm pool address">
-    <configuration name="#computePoolAddress" type="JavaScriptTestRunnerJest" temporary="true" nameIsGenerated="true">
-      <node-interpreter value="project" />
-      <jest-package value="$PROJECT_DIR$/node_modules/jest" />
-      <working-dir value="$PROJECT_DIR$/sdks/v3-sdk" />
-      <envs />
-      <scope-kind value="SUITE" />
-      <test-file value="$PROJECT_DIR$/sdks/v3-sdk/src/utils/computePoolAddress.test.ts" />
-      <test-names>
-        <test-name value="#computePoolAddress" />
-      </test-names>
-      <method v="2" />
-    </configuration>
-    <configuration name="#computePoolAddress.should correctly compute zkevm pool address" type="JavaScriptTestRunnerJest" temporary="true" nameIsGenerated="true">
-      <node-interpreter value="project" />
-      <jest-package value="$PROJECT_DIR$/node_modules/jest" />
-      <working-dir value="$PROJECT_DIR$/sdks/v3-sdk" />
-      <envs />
-      <scope-kind value="TEST" />
-      <test-file value="$PROJECT_DIR$/sdks/v3-sdk/src/utils/computePoolAddress.test.ts" />
-      <test-names>
-        <test-name value="#computePoolAddress" />
-        <test-name value="should correctly compute zkevm pool address" />
-      </test-names>
-      <method v="2" />
-    </configuration>
-    <configuration name="computePoolAddress.test.ts" type="JavaScriptTestRunnerJest" temporary="true" nameIsGenerated="true">
-      <node-interpreter value="project" />
-      <jest-package value="$PROJECT_DIR$/node_modules/jest" />
-      <working-dir value="$PROJECT_DIR$/sdks/v3-sdk" />
-      <envs />
-      <scope-kind value="TEST_FILE" />
-      <test-file value="$PROJECT_DIR$/sdks/v3-sdk/src/utils/computePoolAddress.test.ts" />
-      <method v="2" />
-    </configuration>
-    <recent_temporary>
-      <list>
-        <item itemvalue="Jest.#computePoolAddress.should correctly compute zkevm pool address" />
-        <item itemvalue="Jest.computePoolAddress.test.ts" />
-        <item itemvalue="Jest.#computePoolAddress" />
-      </list>
-    </recent_temporary>
-  </component>
-  <component name="SpellCheckerSettings" RuntimeDictionaries="0" Folders="0" CustomDictionaries="0" DefaultDictionary="application-level" UseSingleDictionary="true" transferred="true" />
-  <component name="TaskManager">
-    <task active="true" id="Default" summary="Default task">
-      <changelist id="622c4fdf-e1f9-44c4-ac1e-dd7a5d3f8c66" name="Changes" comment="" />
-      <created>1714073209620</created>
-      <option name="number" value="Default" />
-      <option name="presentableId" value="Default" />
-      <updated>1714073209620</updated>
-      <workItem from="1714073210785" duration="7575000" />
-      <workItem from="1714651076530" duration="14000" />
-      <workItem from="1716238723141" duration="564000" />
-      <workItem from="1716321028710" duration="19043000" />
-      <workItem from="1718295734001" duration="35704000" />
-    </task>
-    <servers />
-  </component>
-  <component name="TypeScriptGeneratedFilesManager">
-    <option name="version" value="3" />
-  </component>
-</project>
\ No newline at end of file
diff --git a/sdks/v3-sdk/.gitignore b/sdks/v3-sdk/.gitignore
index 705d1452b..37d70ad27 100644
--- a/sdks/v3-sdk/.gitignore
+++ b/sdks/v3-sdk/.gitignore
@@ -63,4 +63,7 @@ jspm_packages/
 .yarn/unplugged
 .yarn/build-state.yml
 .yarn/install-state.gz
-.pnp.*
\ No newline at end of file
+.pnp.*
+
+# JetBrain IDEs
+.idea/
\ No newline at end of file