This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Fix calculation for Trade.minimumAmountOut #44
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #43
Description
The function had a math mistake, but the tests did not catch it because the tests were only checking for small slippage rates. When the slippage rate is 5% or less, the tests did not fail because the result was almost correct when rounded to the nearest whole number. However, when the slippage rate increased, the problem became more obvious.
Additionally, I made a change to the function to prevent a slippage rate of over 100%. It's impossible to lose more than 100% of your money, so setting a slippage rate of over 100% should generate an error.
I had to verify this change, so I modified the tests to reflect these updates.
Screen capture
Here is a manual test on the Uniswap Interface
Test plan
Reproducing the error
Automated testing
yarn test
in your local env to make sure all test pass