Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: account token ownership limit when transfer #1080

Merged
merged 8 commits into from
Jun 25, 2024
Merged

fix: account token ownership limit when transfer #1080

merged 8 commits into from
Jun 25, 2024

Conversation

mrshiposha
Copy link
Contributor

No description provided.

@mrshiposha mrshiposha requested a review from uandysmith June 24, 2024 09:06
@mrshiposha mrshiposha changed the title fix: account token ownership limit when mint fix: account token ownership limit when transfer Jun 25, 2024
CertainLach
CertainLach reviewed Jun 25, 2024
View reviewed changes
runtime/tests/src/tests.rs Outdated
@@ -2405,7 +2405,7 @@ fn owned_tokens_bound_neg() {

let origin1 = RuntimeOrigin::signed(1);

for _ in 1..=MAX_TOKEN_OWNERSHIP {
for _ in 1..MAX_TOKEN_OWNERSHIP {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0..MAX_TOKEN_OWNERSHIP
Это же MAX(tokens.len()) семантически, т.е тут всё верно изначально было

@CertainLach
Copy link
Member

CertainLach commented Jun 25, 2024 •
edited
Loading

Странно что у нас для fungible token ownership limit не обрабатывается, баг?
Токены в апи юника означают именно уникальные, т.е в балансе там имеет смысл только 2 значения - 0 (нельзя иметь баланс) и 1 (можноиметь баланс), т.е в fungible это была бы опция balance_ownership_limit

@CertainLach CertainLach merged commit 0ceea0a into develop Jun 25, 2024
18 of 20 checks passed
@CertainLach CertainLach deleted the fix/account-token-ownership-limit branch June 25, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CertainLach CertainLach CertainLach left review comments

@uandysmith uandysmith uandysmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrshiposha @CertainLach @uandysmith @Maksandre