Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of unused module imports #29

Open
kordejong opened this issue Jan 25, 2024 · 0 comments · May be fixed by #38
Open

Get rid of unused module imports #29

kordejong opened this issue Jan 25, 2024 · 0 comments · May be fixed by #38

Comments

@kordejong
Copy link
Member

The model code is littered with modules that are imported by not used. This slows down the parsing of the code and adds dependencies that are not needed.

A static analyzer like pyright can be used to detect these. I recommend to at least configure a pre-commit hook to detect them before code gets committed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add linting (code formatting) action to the PCR-GLOBWB_model master branch BramDr/PCR-GLOBWB_model
1 participant
@kordejong