Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

social-media-template is missing something? #325

Open
lindsayplatt opened this issue Jan 5, 2018 · 3 comments
Open

social-media-template is missing something? #325

lindsayplatt opened this issue Jan 5, 2018 · 3 comments

Comments

@lindsayplatt
Copy link

When I run vizmake() with the d3 branch of vizstorm , I get a warning about the social media template being unavailable:

In FUN(X[[i]], ...) :
  cannot find dependency '' of viz item 'social-media-template' so cannot include the dependency in remake.yaml

Briefly looking at the line where the warning is thrown, makes me think that it is because I am not including a social media template in my publish step. If so, that warning might be annoyhing. There will probably be times where we don't want to use social media icons.

@ldecicco-USGS
Copy link
Contributor

I tried to make a fully-functional application here:

https://github.com/USGS-VIZLAB/example

In your viz.yaml, co you have something like:

publish: 
   depends:       
      social: social-section
      vertical-social: vertical-social-section
      socialCSS: lib-social-media-css
...
context:
      title: Testing
      sections: [ "social", ]
      resources: [ "socialCSS"]

  -
    id: social-section
    template: social-media-template
    publisher: social
    depends: social-links
    context:
      embedLink: embed-dots.html
      facebookLink: http://www.facebook.com/sharer.php?u=https%3A%2F%2Fowi.usgs.gov%2Fvizlab%2FEXAMPLE%2F
      

At some point I had worked out using and not using the social icons... let me know if this doesn't help and I'll go poking around

@aappling-usgs
Copy link
Member

This is useful sleuthing above. I do wonder how often we won't want to use social media icons AND can't tolerate the warning. Is it possible this is a problem we could leave on the back burner until the time when it's intolerable?

@lindsayplatt
Copy link
Author

Yes, I think we can wait until it becomes unbearably annoying :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants