Unknown command #489
Closed
Unknown command #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar-ish
suggested changes
Nov 13, 2019
| if not handlers: | ||
| self.post_message(command.channel_id, "Unknown command. Use !help to retrieve a list of supported commands") | ||
| else: | ||
| for handler in self._command_registry[command.name]: |
There was a problem hiding this comment.
Could you make this for handler in handlers:? A bit more elegant, is all.
| self.executor.submit(self._execute_catching_error, handler, command) | ||
| handlers = self._command_registry[command.name] | ||
| if not handlers: | ||
| self.post_message(command.channel_id, "Unknown command. Use !help to retrieve a list of supported commands") |
There was a problem hiding this comment.
Split up the String argument onto the next line so that Jenkins doesn't disapprove. It currently says
uqcsbot/base.py:198:101: E501 line too long (120 > 100 characters)
TRManderson
force-pushed
the
master
branch
2 times, most recently
from
354d58e to
2fbec70
Compare
|
@lewisjb I'm just cleaning up these PRs, are you able to make the suggested changes and merge master from upstream? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #471