Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic type-checking and annotations #56

Open
katrinafyi opened this issue Nov 13, 2022 · 1 comment · May be fixed by #134
Open

Basic type-checking and annotations #56

katrinafyi opened this issue Nov 13, 2022 · 1 comment · May be fixed by #134
Labels
enhancement update an existing command or cog for some new functionality help wanted Extra attention is needed

Comments

@katrinafyi
Copy link
Member

It would be nice to have some type-checking (like mypy) which runs on the CI build. This would help catch bugs such as those in #54 and is easier than comprehensive unit testing.

I have vague memories of UQComputingSociety/uqcsbot-slack having this, though I might be mixing it up with ordinary unit tests (which are also not on Discord, but that's #2).

I would do this myself but I suspect the bot is currently in a state of discord.py limbo. Maybe whenever that is sorted out.

@JamesDearlove JamesDearlove added enhancement update an existing command or cog for some new functionality help wanted Extra attention is needed labels Nov 13, 2022
@JamesDearlove
Copy link
Member

Hoping to have discord.py limbo sorted soon™ @kumar-ish mentioned this in his PR and it's a good idea to have something like this

@andrewj-brown andrewj-brown linked a pull request Jul 1, 2023 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement update an existing command or cog for some new functionality help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants