Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize memory sharing in UCDD library #35

Open
magoorden opened this issue Jul 26, 2022 · 1 comment
Open

Minimize memory sharing in UCDD library #35

magoorden opened this issue Jul 26, 2022 · 1 comment

Comments

@magoorden
Copy link
Contributor

cdd_info(state.root)-->type == TYPE_BDD

I wonder how did it work before? :-/
This is such a mess of memory sharing, which needs to be rewritten with move semantics instead.

Originally posted by @mikucionisaau in #31 (comment)

@mikucionisaau
Copy link
Member

That comment was due to the changes in that PR where root is private and handle() was a new public method to access it.
Later I found that .root worked due to the fact that the owner structure has many function friends, which enabled access to private fields in many places.
I think the intention was to have a tight control over which functions can access the internals ('private' members), so perhaps it is worthwhile continueing it like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants