Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_reduce fails for size = 3 #19

Open
magoorden opened this issue Jun 17, 2022 · 1 comment
Open

test_reduce fails for size = 3 #19

magoorden opened this issue Jun 17, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@magoorden
Copy link
Contributor

The tests in this library are not runned frequently. For #16, I am creating a test case and thus enabling running test_cdd again. I noticed that the current test fails for test_reduce with input size = 3:

test_cdd: /home/martijn/Documents/UCDD/test/test_cdd.cpp:223: void test_reduce(size_t): Assertion `cdd2 == cdd3' failed.
@mikucionisaau
Copy link
Member

mikucionisaau commented Jun 17, 2022

Yes, that's the reason the test with size=10 is disabled for 64bits.
Interestingly it passes for 32 bits.
Which means there is some aweful C code messing with integer/pointer sizes.
I think we need to revise all the code concerning the pseudo-hashing using pointers.
They probably assume 32bit pointer arithmetic, but something goes wrong.

@mikucionisaau mikucionisaau added the bug Something isn't working label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants