Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore turning strict on for Typescript #761

Open
NicMcPhee opened this issue Feb 13, 2022 · 0 comments
Open

Explore turning strict on for Typescript #761

NicMcPhee opened this issue Feb 13, 2022 · 0 comments
Labels
enhancement javascript Pull requests that update Javascript code

Comments

@NicMcPhee
Copy link
Member

NicMcPhee commented Feb 13, 2022

If you set strict = true in tsconfig.js, all kinds of red pops up, a lot of which has to do with the possibility that various things could be null or undefined, but we don't handle that gracefully (or at all). In many cases this is the result poor to nonexistent error handling. In other cases, however, it's just complicated because we "know" (because of how Angular works) that something will have a value, but TS can't figure that out.

I feel like we should at least make a significant effort to fix this, but it's definitely not happening now with this lab having to go out in a day or so. Maybe it's something I look at on sabbatical.

This will carry through to Lab 4 and the iteration template.

This may help surface error handling issues for #762.

@NicMcPhee NicMcPhee added enhancement javascript Pull requests that update Javascript code labels Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

1 participant