Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create templated versions of EigenHelpersConversions helpers #33

Open
dmcconachie opened this issue Nov 28, 2017 · 1 comment
Open

Create templated versions of EigenHelpersConversions helpers #33

dmcconachie opened this issue Nov 28, 2017 · 1 comment

Comments

@dmcconachie
Copy link
Contributor

dmcconachie commented Nov 28, 2017

For example, right now we would need 4 different functions for the following:

inline geometry_msgs::Pose EigenIsometry3fToGeometryPose(const Eigen::Isometry3f& transform);
inline geometry_msgs::Pose EigenIsometry3dToGeometryPose(const Eigen::Isometry3d& transform);
inline geometry_msgs::Pose EigenAffine3fToGeometryPose(const Eigen::Affine3f& transform);
inline geometry_msgs::Pose EigenAffine3dToGeometryPose(const Eigen::Affine3d& transform);

There are many such functions that would need to be duplicated. I think templates is by far the better way to go for this.

@dmcconachie
Copy link
Contributor Author

Instead of replacing the existing interface, we could instead leave the existing interface alone for backwards compatibility, and have the existing functions call the templated versions. Not sure if this sort of backwards compatability is valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant