You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In short, in notify-edit.js take a look at NotifyEdit.usableKeys. It is a bit of a chain hell, sorry! Essentially it's mapping out all of the component names and prepending the section it's in, if it has one. eg yourDetails.name
For context
In the runner Summary.js is doing a flatten on the state so you'll end up with {yourDetails.name: 'jen'}, and so NotifyService can send the personalisation (yourDetails.name) and it's value, jen.
We'd want the new feature (and possibly this notify one, for clarity to the user) to return an object, with the section, name, and title. We would serve the user the title, but use the section.name for the values.
I would imagine we could just construct the condition as a string as they are at the moment. I'd just be careful with what expr-eval accepts (like 'and' rather than &&).
The text was updated successfully, but these errors were encountered:
As per hack day discussions (sorry I couldn't attend!), conditions need to be more user friendly.
@andymoody
In short, in
notify-edit.js
take a look atNotifyEdit.usableKeys
. It is a bit of a chain hell, sorry! Essentially it's mapping out all of the component names and prepending the section it's in, if it has one. egyourDetails.name
For context
In the runner
Summary.js
is doing a flatten on the state so you'll end up with{yourDetails.name: 'jen'}
, and so NotifyService can send the personalisation(yourDetails.name)
and it's value, jen.We'd want the new feature (and possibly this notify one, for clarity to the user) to return an object, with the section, name, and title. We would serve the user the title, but use the section.name for the values.
I would imagine we could just construct the condition as a string as they are at the moment. I'd just be careful with what expr-eval accepts (like 'and' rather than &&).
The text was updated successfully, but these errors were encountered: