Skip to content

Home

Jump to bottom
Phill Conrad edited this page Feb 17, 2016 · 15 revisions

Welcome to the W16-lab04 wiki!

HOW TO DEAL WITH PULL REQUESTS (as a moderator) for lab04

This example assumes that cgaucho is the github.com id of the student doing a pull request.

Steps 1 and 2 are no longer necessary, because github updated their permission model for repos that belong to organizations.

Step 3: Create a feedback repo for student.

Under the UCSB-CS56-W16 organization create a PRIVATE repo called cs56_w16_feedback_cgaucho.

It should have a README.md, but it need not have a gitignore or a license.

Step 4: Add the student as a collaborator on the student's feedback repo.

Go to settings, collaborators, add the student by their github id.

Step 5: In the repo, create a file called lab04_feedback.md (which can be done directly in the github.com web interface by clicking the'+' after the repo name/--you do NOT need to clone, etc. unless you really really want to.)

In that file, copy paste the following text below (Sample Rubric as Github Flavored Markdown Table).

Step 6: Moderator fills in ONLY the +-o? column and the comments column.

THEN the moderator is ready to accept the pull request. You can also comment on the pull request directly in the github.com UI, by commenting on lines of source code in the usual way.

Sample Rubric as Github Flavored Markdown Table

Feedback goes into a PRIVATE repo on github.com under the UCSB-CS56-W16 organization, that is shared ONLY with that individual student.

Normally we do that with scripts, but we might or might not end up doing that by hand this year if it ends up being easier--especially if we can divide up the work and have each of the moderators do that as they handle the feedback for each pull request. It doesn't take long, and it only has to be done once per student per quarter.

Here's the raw stuff to copy/paste. Each moderator should copy/paste this into the feedback, and then fill out ONLY the +o-? column, and the comments column.

to do the grading we need to change the line in the build.xml file that starts with to the real student csil username.

** or you can use >> export USER="csilUsername" from the command line to tell ant to access the proper package **

THEN: the TA or instructor fills in the numbers in the grade column, totals, and posts the grade to Gauchospace.

* + o - are indications from Moderator's review
 * o is **ok**, met expectations (no deductions),
 * - **below expectations** (deduction might be made by TA or instructor), 
 * + means **exceeds expectations** 
  * In rare cases, instructor or TA might award points to offset other deductions. No guarantee of this.
 * ? is a flag used by moderators to raise a **question** for the TA to investigate further
* Poss: Possible Points
* Pts: Points Awarded (only filled in by TA or Instructor, NOT by moderator)

| Item | +o?-  | Poss | Pts | Summary | Comments  
|------|-------|------|-----|-------------|-----------
| SG1  |      |  20  |     | SimpleGui1 text, color | 
| **Item** | **+o?-**| **Poss** | **Pts** | **Summary** | **Comments**  
| SN1  |       |  40  |     | Snowman has head   |
| **Item** | **+o?-**| **Poss** | **Pts** | **Summary** | **Comments**  
| C1   |       |  20  |     | correct package   |
| C2   |       |  20  |     | extend GeneralPathWrapper, implement Shape    |
| C3   |       |  50  |     | one class inherits from other    |
| C4   |       |  40  |     | constructor inits wrapper GP object |
| C5   |       |  40  |     | object looks reasonable    |
| C6   |       |  40  |     | coding style good  |
| **Item** | **+o?-**| **Poss** | **Pts** | **Summary** | **Comments**  
| GP   |       |  30  |     | followed instructions   |

Here's what it looks like when formated:

    • o - are indications from Moderator's review
  • o is ok, met expectations (no deductions),
    • below expectations (deduction might be made by TA or instructor),
    • means exceeds expectations
  • In rare cases, instructor or TA might award points to offset other deductions. No guarantee of this.
  • ? is a flag used by moderators to raise a question for the TA to investigate further
  • Poss: Possible Points
  • Pts: Points Awarded (only filled in by TA or Instructor, NOT by moderator)
Item +o?- Poss Pts Summary Comments
SG1 20 SimpleGui1 text, color
Item +o?- Poss Pts Summary Comments
SN1 40 Snowman has head
Item +o?- Poss Pts Summary Comments
C1 20 correct package
C2 20 extend GeneralPathWrapper, implement Shape
C3 50 one class inherits from other
C4 40 constructor inits wrapper GP object
C5 40 object looks reasonable
C6 40 coding style good
Item +o?- Poss Pts Summary Comments
GP 30 followed instructions

Lab06 Rubric: don't forget to git checkout animbranch before grading!


* + o - are indications from Moderator's review
 * o is **ok**, met expectations (no deductions),
 * - **below expectations** (deduction might be made by TA or instructor), 
 * + means **exceeds expectations** 
  * In rare cases, instructor or TA might award points to offset other deductions. No guarantee of this.
 * ? is a flag used by moderators to raise a **question** for the TA to investigate further
* Poss: Possible Points
* Pts: Points Awarded (only filled in by TA or Instructor, NOT by moderator)


| Item | +o?-  | Poss | Pts | Summary | Comments  
|------|-------|------|-----|-------------|-----------
| SG1  |      |  50  |     | in correct branch | 
| **Item** | **+o?-**| **Poss** | **Pts** | **Summary** | **Comments**  
| SN1  |       |  50  |     | animation works  |
| **Item** | **+o?-**| **Poss** | **Pts** | **Summary** | **Comments**  
| C1   |       |  50  |     | coding style   |
| **Extra Credit** | **+o?-**| **Poss** | **Pts** | **Summary** | **Comments**  
| GP   |       |  0-50 Extra Credit  |     | animation is AWESOME!   |
Clone this wiki locally