From aa98926a325fbdba3679e766bd34f8fb111b88fb Mon Sep 17 00:00:00 2001
From: Tatiana Smirnova <tatiana.smirnova@nopio.com>
Date: Thu, 3 Oct 2024 01:05:37 +0200
Subject: [PATCH] fix: NOP-29 Add comma to number of results on search results
 page (#1162)

Co-authored-by: Andy Wallace <andrewwallace@library.ucla.edu>
---
 app/views/catalog/_browse_results.html.erb                     | 3 ++-
 .../catalog/banners/_collection_masthead_overlay.html.erb      | 2 +-
 app/views_legacy/catalog/_paginate_compact.html.erb            | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/app/views/catalog/_browse_results.html.erb b/app/views/catalog/_browse_results.html.erb
index ec8d811a8..c78997fb7 100644
--- a/app/views/catalog/_browse_results.html.erb
+++ b/app/views/catalog/_browse_results.html.erb
@@ -13,7 +13,8 @@
   <% else %>
     <div class='search-count-wrapper'>
       <h2 class='search-count__heading'>
-        <span class="search-count__results-found"><%= @response['response'].dig(:numFound) %></span> <span class="search-count__catalog-results">Catalog Results</span>
+        <span class="search-count__results-found"><%= number_with_delimiter @response['response'].dig(:numFound) %></span>
+        <span class="search-count__catalog-results">Catalog Results</span>
       </h2>
       <%= render_results_collection_tools wrapping_class: "search-widgets search-widgets-wrapper search-widgets-wrapper--sinai" %>
     </div>
diff --git a/app/views/catalog/banners/_collection_masthead_overlay.html.erb b/app/views/catalog/banners/_collection_masthead_overlay.html.erb
index 621a4ac6c..ba4f86339 100644
--- a/app/views/catalog/banners/_collection_masthead_overlay.html.erb
+++ b/app/views/catalog/banners/_collection_masthead_overlay.html.erb
@@ -2,7 +2,7 @@
   <h1 class='banner__title--collection'><%= document[:title_tesim][0] %></h1>
   <div class='banner__collection-detail'>
     <% if collection_count %>
-    <div class='banner__collection-count' itemprop="collectionSize"><%= collection_count %> items</div>
+    <div class='banner__collection-count' itemprop="collectionSize"><%= number_with_delimiter collection_count %> items</div>
     <% end %>
     <%= link_to 'Browse items in this collection', "/catalog?f%5Bmember_of_collections_ssim%5D%5B%5D=#{CGI.escape(document[:title_tesim][0])}", class: 'btn-base btn-outline-ursus--gold ur-link--gold banner__overlay-btn-text' %>
   </div>
diff --git a/app/views_legacy/catalog/_paginate_compact.html.erb b/app/views_legacy/catalog/_paginate_compact.html.erb
index d631518ab..aa140ec65 100644
--- a/app/views_legacy/catalog/_paginate_compact.html.erb
+++ b/app/views_legacy/catalog/_paginate_compact.html.erb
@@ -3,5 +3,5 @@
 
 <%= render :partial => "paginate_compact", :object => @response-%>
 
-<h4><b><%= @response['response'].dig(:numFound) %></b> Catalog Results</h4>
+<h4><b><%= number_with_delimiter @response['response'].dig(:numFound) %></b> Catalog Results</h4>
 <%= paginate paginate_compact, :page_entries_info => page_entries_info(paginate_compact), :theme => :blacklight_compact %>