Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirements.yml from template #10

Closed
p-j-smith opened this issue Apr 14, 2024 · 4 comments · Fixed by #12
Closed

Remove requirements.yml from template #10

p-j-smith opened this issue Apr 14, 2024 · 4 comments · Fixed by #12

Comments

@p-j-smith
Copy link

Short Description

The template contains a requirements.yml, which suggests using it for creating an Ansible role / collection. We could either use the official template for Ansible Collections (https://github.com/ansible-collections/collection_template), or create our own under UCL-ARC with molecule testing and github workflows set up.

Details

No response

Next Steps/Accepted Response

No response

@p-j-smith p-j-smith added the question Further information is requested label Apr 14, 2024
@paddyroddy
Copy link
Member

paddyroddy commented Apr 15, 2024

You can remove the requirements.yml if you feel it is inappropriate - but I would argue we still need the template. It may seem obvious to us, but it's really good if we can include pre-commit & @renovatebot + CI in all new repos.

@paddyroddy
Copy link
Member

I think I included it just to make this work

ansible-roles-config: ./requirements.yml
which obviously is silly in this example

@p-j-smith
Copy link
Author

I would argue we still need the template. It may seem obvious to us, but it's really good if we can include pre-commit & https://github.com/renovatebot + CI in all new repos.

Yeah that's true. Even if a new repo is created using a different template, it's still useful to be able to copy these files quickly from this repo

I think I included it just to make this work

I think that ansible-roles-config (and requirements.yml) can be removed from this repo now that the default is missing

@p-j-smith p-j-smith changed the title Do we still need this tempalte? Remove requirements.yml from template Apr 16, 2024
@p-j-smith p-j-smith removed the question Further information is requested label Apr 16, 2024
@paddyroddy
Copy link
Member

I think that ansible-roles-config (and requirements.yml) can be removed from this repo now that the default is missing

Agreed. The default was actually always missing, I think I just did it in case people didn't know how to lint with ansible. But it probably causes more confusion than it solves.

paddyroddy added a commit that referenced this issue Apr 16, 2024
Realistically this is not always required. I included it to make it
obvious for people who didn't know, but it causes more confusion than it
solves. Fixes #10.
paddyroddy added a commit that referenced this issue Apr 22, 2024
Realistically this is not always required. I included it to make it
obvious for people who didn't know, but it causes more confusion than it
solves. Fixes #10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants