Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frcmod should not misapply terms to the new possible combinations #72

Closed
bieniekmateusz opened this issue Apr 3, 2020 · 4 comments
Closed
Assignees
Labels
dev Old and most likely irrelevant

Comments

@bieniekmateusz
Copy link
Contributor

Inspired by #71

Read the left.prmtop and right.prmtop and compare it to the morph.prmtop - to ensure that the new forcefield applies them correctly, and does not misapply any of the existing rules.

@bieniekmateusz bieniekmateusz self-assigned this Apr 3, 2020
@bieniekmateusz
Copy link
Contributor Author

One possible approach might be taking the .prmtop files from each ligand separately and merging them manually, rather than introducing the inbetween step with the .frcmod. Since the assumption is that the original forcefield prmstop is completely correct. This would probably not be easy though.

A good measure for this is to extract the parameters and functions (angles/dihedrals etc) which are applied on each atom and compare them initially and at the end.

@bieniekmateusz
Copy link
Contributor Author

Most importantly, it would be useful to have a check for this, which should not be too difficult to write. Just so that we do not let the cases where it does not work through.

bieniekmateusz added a commit that referenced this issue Apr 3, 2020
…toms. This means that fake force=0 terms for the forcefield have to be sometimes introduced. This solution is copied from https://github.com/UCL-CCS/BacScratch/blob/master/agastya/ties_hybrid_topology_creator/output.py#L106 and should be refined if necessaryin #72
@bieniekmateusz bieniekmateusz pinned this issue Apr 4, 2020
@bieniekmateusz
Copy link
Contributor Author

After further thought, this should not be a problem, because NAMD most likely does not respect these terms and ignores them. So it should be all fine - however - saying that, it would be very easy to apply a test for this case. So I might do jus that.

@bieniekmateusz
Copy link
Contributor Author

So Shunzhou confirmed that NAMD will not respect these values.

Another question in this topic is to ensure that the new term does not misapply. For example, is it possible that to run into two .frcmod lines that apply to the same atom combination, but have different force?

@bieniekmateusz bieniekmateusz added the dev Old and most likely irrelevant label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Old and most likely irrelevant
Projects
None yet
Development

No branches or pull requests

1 participant