Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic md class #46

Open
kristofarkas opened this issue Jul 25, 2017 · 0 comments
Open

Generic md class #46

kristofarkas opened this issue Jul 25, 2017 · 0 comments
Assignees
Milestone

Comments

@kristofarkas
Copy link
Collaborator

The problem is: that we want gromacs.Run and namd.Run (and potentially all other engine classes) to be convertible between each other, i.e. md_gromacs = gmx.Run(md=md_namd) or something like that should work.

The original idea was to make some kind of abstract superclass that contains all the attributes from gromacs and namd configuration files, but the two are too dissimilar for this approach to work. Some parts translate very nicely (1:1), but some don't. This is why there are separate modules for each.

The "solution" was to have some kind of generic md class which has all the attributes one can imagine, and then every actual md class cherry-picks the ones it understands (going through a converter).

To be honest, I'm not sure if this is the best way to do it. See what happens once I start implementing it.

@kristofarkas kristofarkas added this to the Sprint 4 milestone Jul 25, 2017
@kristofarkas kristofarkas self-assigned this Jul 25, 2017
@kristofarkas kristofarkas modified the milestones: Sprint 5, Sprint 4 Aug 3, 2017
kristofarkas pushed a commit that referenced this issue Aug 3, 2017
They are being renamed to `simulation` and `workflow`. `simulation` is also related to #46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant