Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is data, why is sized as it is #6

Open
johnramsden opened this issue Oct 25, 2020 · 3 comments
Open

What is data, why is sized as it is #6

johnramsden opened this issue Oct 25, 2020 · 3 comments

Comments

@johnramsden
Copy link
Collaborator

PIM-Embedding-Lookup/upmem/src/dpu/emb_dpu_lookup.c

Line 13 in 1830cfb

__mram_noinit int32_t data[8];

data doesn't appear to be used yet, what is it supposed to represent? Perhaps it's size should also be a constant so that we can easily tell what it represents.
@nzarif
Copy link
Collaborator

nzarif commented Oct 28, 2020 •
edited
Loading

TBH, I don't know. As far as I remember Abbas has written this code.

@johnramsden
Copy link
Collaborator Author

Perhaps it should be removed?

@nzarif
Copy link
Collaborator

nzarif commented Oct 28, 2020

I agree. It seems to be something that was meant to be used for testing purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnramsden @nzarif