Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package run targets should depend on Aegisub #230

Open
guijan opened this issue Dec 21, 2024 · 0 comments
Open

Package run targets should depend on Aegisub #230

guijan opened this issue Dec 21, 2024 · 0 comments

Comments

@guijan
Copy link
Contributor

guijan commented Dec 21, 2024

We have Meson run targets to make installers and the like such as this one:

run_target('win-installer',
command: [installer_setup, meson.project_build_root(), meson.project_source_root()])

However, they don't depend on the targets they're packaging. This means Meson can't automatically rebuild them when their dependencies are modified, and producing installers isn't as simple as this:

meson setup build && meson compile -C build win-installer

Instead, because the dependency on the rest of Aegisub is missing, it looks more like this:

meson setup build && meson compile -C build && meson compile -C build win-installer

And you have to remember to rerun meson compile -C build after any changes if you want to make a new installer.

Ideally, these run targets would be reviewed and changed to look more like this:

    run_target('win-installer',
               command: [installer_setup, meson.project_build_root(), meson.project_source_root()],
               depends: [aegisub_exe, docs, whatever])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant