Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatability with KineticYeet 1.2.0 causes all armor to fully break on death #145

Closed
Arsoth opened this issue Nov 19, 2024 · 2 comments
Closed
Labels
bug Something isn't working as expected Fabric Issues occurring on the Fabric platform Minecraft 1.21 Issues occurring in Minecraft 1.21.x

Comments

@Arsoth
Copy link

Arsoth commented Nov 19, 2024

Minecraft Version

1.21.1 (LTS)

Mod Loader

Fabric

Mod Version

21.1.5

Describe the Issue

Steps to reproduce:

  1. Install Hardcore Revival and KineticYeet (1.2.0)
    image
  2. Die wearing armor
  3. You hear the sound of armor breaking and all your armor is now missing from the loot pile. Grave mods such as You're in Grave Danger and Universal Graves do not retain the armor either. This even occurs with the What Durability mod, which removes all durability from items.

I'm cross posting this to both mod authors repos (HCR bug report, KY bug report; I can't even begin to figure out what's causing this and it's only because I know about binary searches I was able to narrow it down to these two.

Logs

I truly wish there was any log to explain these shenanigans. The logs are totally normal:

[19:26:32] [Server thread/INFO]: Arsoth[local:E:5adc0150] logged in with entity id 1 at (-5.5, -60.0, 3.5)
[19:26:32] [Server thread/INFO]: Arsoth joined the game
[19:26:32] [Render thread/INFO]: Loaded 2 advancements
[19:26:40] [Server thread/INFO]: [Arsoth: Set own game mode to Creative Mode]
[19:26:40] [Render thread/INFO]: [System] [CHAT] Set own game mode to Creative Mode
[19:26:47] [Server thread/INFO]: Arsoth has made the advancement [Suit Up]
[19:26:47] [Render thread/INFO]: [System] [CHAT] Arsoth has made the advancement [Suit Up]
[19:26:47] [Render thread/INFO]: Loaded 10 advancements
[19:27:07] [Server thread/INFO]: [Arsoth: Set own game mode to Survival Mode]
[19:27:07] [Render thread/INFO]: [System] [CHAT] Set own game mode to Survival Mode
[19:27:13] [Server thread/INFO]: Arsoth died
[19:27:13] [Server thread/INFO]: [Arsoth: Killed Arsoth]
[19:27:13] [Render thread/INFO]: [System] [CHAT] Arsoth died
[19:27:13] [Render thread/INFO]: [System] [CHAT] Killed Arsoth
[19:27:16] [Server thread/INFO]: Arsoth was not rescued in time
[19:27:16] [Render thread/INFO]: [System] [CHAT] Arsoth was not rescued in time
[19:27:32] [Server thread/INFO]: Saving and pausing game...
[19:27:32] [Server thread/INFO]: Saving chunks for level 'ServerLevel[AAAAAAAAAAAAAA?]'/minecraft:overworld
[19:27:32] [Server thread/INFO]: Saving chunks for level 'ServerLevel[AAAAAAAAAAAAAA?]'/minecraft:the_nether
[19:27:32] [Server thread/INFO]: Saving chunks for level 'ServerLevel[AAAAAAAAAAAAAA?]'/minecraft:the_end
[19:29:01] [Server thread/INFO]: Arsoth lost connection: Disconnected
[19:29:01] [Server thread/INFO]: Arsoth left the game
[19:29:01] [Server thread/INFO]: Stopping singleplayer server as player logged out

Do you use any performance-enhancing mods (e.g. OptiFine) or custom server distributions (e.g. SpongeForge or Arclight)?

no

@Arsoth
Copy link
Author

Arsoth commented Nov 20, 2024

This has been marked as wontfix on kinetic yeets side.

@BlayTheNinth
Copy link
Member

Realistically I will not be looking into this because KineticYeet does not actually have any source code available on its GitHub. Without seeing its code, it's hard to say what's happening or to pinpoint the source.

Based on having no other information and the fact that the issue revolves around armor, which KineticYeet is much more likely to interact with, I wouldn't agree with their assessment that this needs to be fixed in Hardcore Revival. However, they are free to provide details or submit a pull request if this is truly a bug in Hardcore Revival.

@BlayTheNinth BlayTheNinth added Fabric Issues occurring on the Fabric platform Minecraft 1.21 Issues occurring in Minecraft 1.21.x labels Nov 20, 2024
@BlayTheNinth BlayTheNinth moved this to 📧 On Hold in Issues Nov 21, 2024
@BlayTheNinth BlayTheNinth closed this as not planned Won't fix, can't repro, duplicate, stale Dec 25, 2024
@github-project-automation github-project-automation bot moved this from 📧 On Hold to 🎉 Done in Issues Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected Fabric Issues occurring on the Fabric platform Minecraft 1.21 Issues occurring in Minecraft 1.21.x
Projects
Archived in project
Development

No branches or pull requests

2 participants