Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable shadow parameters on blocks as part of fixing #21

Open
ajskateboarder opened this issue Apr 4, 2024 · 3 comments
Open

Disable shadow parameters on blocks as part of fixing #21

ajskateboarder opened this issue Apr 4, 2024 · 3 comments

Comments

@ajskateboarder
Copy link

Every block object in the project.json has a shadow parameter which is usually false, but when set to true manually, hides the block from the editor. It would be nice to have sb3fix set the shadow attribute back to false as a fix.

@GarboMuffin
Copy link
Member

GarboMuffin commented Apr 5, 2024

usually we only add things to sb3fix in response to a broken .sb3 file, do you have an example?

(yes I know what shadow does, i've played with it before, but is there any proof of this actually being used? fixing this in the general case may also be hard but we can apply more specific fixes for specific broken files)

@ajskateboarder
Copy link
Author

ajskateboarder commented Apr 5, 2024

usually we only add things to sb3fix in response to a broken .sb3 file, do you have an example?

I've encountered a few projects using them that were eventually unshared, but here's one that remains shared: https://scratch.mit.edu/projects/388355119/

@aliasfoxkde
Copy link

Pi Prover in 0 blocks.sb3.zip
Pi Prover in 0 blocks_Fixed.sb3.zip

I wasn't sure at first, but I think I'd second this. Maybe add a checkbox you can select when fixing (instead of just auto, but I think that would be fine as well), that can do a find/replace (sorry if that's too simple an analogy and might be more difficult) of "shadow":true --> "shadow":false for the project.json? I did it manually (notepad++) and it fixed the issue, but I'm still not sure how you manually change this in the editor. Please see the attached files.

Of course, the issue is a hack I think (less of a mistake someone will likely make), so if you don't implement, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants