-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Time Extension #752
Conversation
Added several new blocks that help calculate differences in time and data about time and calenders.
Yeah I believe Its since -days arent real and it confuses the system. I experienced a lot of bugs because of day 0's in this lol |
extensions/-SIPC-/time.js
Outdated
id: 'sipctime', | ||
id: 'time', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.turbowarp.org/development/extensions/compatibility#the-extension-id-must-never-change
and new extensions are required to be based on something like the creator's username (to prevent conflicts)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the issue, also added credits and stuff. Anything else I need to fix? Also are you able to verify this or is it Garbo?
actually just read https://docs.turbowarp.org/development/extensions/compatibility in its entirety, because a lot of these changes break compatibility i think (like changing opcode/argument capitalization). in this case, i don't think you would need to duplicate any blocks or create a new extension; the user will not usually see block opcodes or argument ids anyways |
-Fixed minor bugs -Fixed Linting errors
Can you rebase this? |
Yep! Done :))) |
Moved to: #928 |
MOVED: #928
Added several new blocks that help calculate differences in time and data about time and calendars. Also made minor changes to the code.