Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Time Extension #752

Closed
wants to merge 4 commits into from
Closed

Conversation

SharkPool-SP
Copy link
Collaborator

@SharkPool-SP SharkPool-SP commented Jul 16, 2023

MOVED: #928

Added several new blocks that help calculate differences in time and data about time and calendars. Also made minor changes to the code.
New Blocks

Added several new blocks that help calculate differences in time and data about time and calenders.
@WeirdBoi12408
Copy link

WeirdBoi12408 commented Jul 17, 2023

image
Hmm... if the inputs are outside of the domain then it behaves interestingly.

Still an interesting extension though.

@SharkPool-SP
Copy link
Collaborator Author

Yeah I believe Its since -days arent real and it confuses the system. I experienced a lot of bugs because of day 0's in this lol

Comment on lines 8 to 12
id: 'sipctime',
id: 'time',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.turbowarp.org/development/extensions/compatibility#the-extension-id-must-never-change
and new extensions are required to be based on something like the creator's username (to prevent conflicts)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue, also added credits and stuff. Anything else I need to fix? Also are you able to verify this or is it Garbo?

@CST1229
Copy link
Collaborator

CST1229 commented Jul 17, 2023

actually just read https://docs.turbowarp.org/development/extensions/compatibility in its entirety, because a lot of these changes break compatibility i think (like changing opcode/argument capitalization). in this case, i don't think you would need to duplicate any blocks or create a new extension; the user will not usually see block opcodes or argument ids anyways

@SharkPool-SP SharkPool-SP requested a review from CST1229 July 18, 2023 04:03
@GarboMuffin
Copy link
Member

Can you rebase this?

@SharkPool-SP
Copy link
Collaborator Author

Can you rebase this?

Yep! Done :)))

@SharkPool-SP
Copy link
Collaborator Author

Moved to: #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants