Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt-in feature #50

Open
AzHicham opened this issue Mar 29, 2024 · 1 comment
Open

Opt-in feature #50

AzHicham opened this issue Mar 29, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@AzHicham
Copy link
Contributor

In order to reduce compile time / complexity.
It could be nice to make tch-rs and ndarray option feature.
WDYT ?
@Tudyx
Copy link
Owner

Tudyx commented Apr 1, 2024

Good idea 👍
tch-rs is already under a features flag as it is optional. We should move it to an explicit features as it will become the default for the 2024 edition.
We can also feature gate ndarray for sure.

We would then have to choose a default back-end then, using the default feature.

What do you use the most, ndarray or tch-rs?

@Tudyx Tudyx added the good first issue Good for newcomers label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AzHicham @Tudyx