Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API - Get Content Notes of an Account Endpoint #12

Closed
5 tasks done
AMAN-BARBARIA opened this issue Aug 1, 2023 · 2 comments
Closed
5 tasks done

API - Get Content Notes of an Account Endpoint #12

AMAN-BARBARIA opened this issue Aug 1, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request task Ticket to work on
Milestone

Comments

@AMAN-BARBARIA
Copy link
Member

AMAN-BARBARIA commented Aug 1, 2023

Goal: Implement an API endpoint to fetch a list of content notes associated with a particular Salesforce account sorted by last creation time. This endpoint should handle Salesforce access token lifecycle, refreshing it as necessary.

Background: For our Salesforce integration, we need to fetch and display the content notes associated with specific accounts. Salesforce access tokens have a limited lifespan, so our implementation needs to handle token expiration and refresh.

Tasks:

  • Implement a new API endpoint to fetch content notes from Salesforce.
  • The endpoint should add the current Salesforce access token to the request before sending it.
  • If a request fails due to an expired access token, the endpoint should automatically refresh the token and retry the request once.
  • Implement error handling for other error cases, such as invalid requests or server errors.
  • Write tests for the new endpoint
@AMAN-BARBARIA AMAN-BARBARIA converted this from a draft issue Aug 1, 2023
@AMAN-BARBARIA AMAN-BARBARIA added enhancement New feature or request task Ticket to work on labels Aug 1, 2023
@AMAN-BARBARIA
Copy link
Member Author

AMAN-BARBARIA commented Aug 1, 2023

@AMAN-BARBARIA AMAN-BARBARIA added this to the v0.1.0 milestone Aug 1, 2023
@AMAN-BARBARIA
Copy link
Member Author

We can make use of Interceptor Pattern to reuse the common code. eg:

  • Fetch Access Token
  • Decrypt with KMS
  • Exception Handling
  • Handle oauth access token Expiry: refresh token and retry salesforce api

@yagnik159 yagnik159 moved this from Ready to Dev QA in SalesSparrow Aug 10, 2023
@yagnik159 yagnik159 moved this from Dev QA to In Review in SalesSparrow Aug 16, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in SalesSparrow Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request task Ticket to work on
Projects
Status: Done
Development

No branches or pull requests

2 participants