Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: minor CSS touch-ups for mobile support #141

Merged
merged 1 commit into from
May 23, 2021
Merged

Conversation

TrueBrain
Copy link
Owner

During testing for release, I found a few things that bugged me enough to fix it:

  • Padding in header was 6px top, 10px bottom. This is fine for desktop, but on mobile it looked really weird. So changed that for both to 6px both.
  • width: 100% causes images that are uploaded too big but are suppose to render smaller, to size badly. This would be a huge regression for all wiki's using TrueWiki. So I reverted that part. It will make big images boom on mobile, so we do need to find a solution there. This just isn't that ;)
  • Changed the min-width from 992px, which feels random, to 1020px, the size of the header. This mostly removes an odd period where we do make the header smaller, before going to full mobile. This works for the default CSS, but any wiki making changes to the header is having a hard time with it. And those 30 pixels are not really going to make a difference in day-to-day use.
  • The search-bar is relative, and as such uses height (even despite the object not being there). This creates a weird gap between header and main. Fix this by using a negative margin if non-mobile.

@TrueBrain TrueBrain added the changelog: hide This Pull Request should not be mentioned in the changelog label May 23, 2021
@TrueBrain TrueBrain merged commit deb7282 into main May 23, 2021
@TrueBrain TrueBrain deleted the fix-css-mobile branch May 23, 2021 10:15
@TrueBrain
Copy link
Owner Author

@Qrbaker : I had to revert the width: 100% on images; I need to look at it better to find a solution that works for existing wikis (read: OpenTTD's) and still work on mobile. I created an issue for it :) (#142)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: hide This Pull Request should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant