Fix: minor CSS touch-ups for mobile support #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing for release, I found a few things that bugged me enough to fix it:
width: 100%
causes images that are uploaded too big but are suppose to render smaller, to size badly. This would be a huge regression for all wiki's using TrueWiki. So I reverted that part. It will make big images boom on mobile, so we do need to find a solution there. This just isn't that ;)992px
, which feels random, to1020px
, the size of the header. This mostly removes an odd period where we do make the header smaller, before going to full mobile. This works for the default CSS, but any wiki making changes to the header is having a hard time with it. And those 30 pixels are not really going to make a difference in day-to-day use.relative
, and as such uses height (even despite the object not being there). This creates a weird gap betweenheader
andmain
. Fix this by using a negative margin if non-mobile.